From: Huang Jianan <huangjianan@xiaomi.com>
To: Wu Bo <bo.wu@vivo.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Wu Bo <wubo.oduw@gmail.com>, Jaegeuk Kim <jaegeuk@kernel.org>,
"linux-f2fs-devel@lists.sourceforge.net"
<linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [External Mail][f2fs-dev] [PATCH 05/13] f2fs: set inline tail flag when create inode
Date: Tue, 3 Sep 2024 09:49:00 +0000 [thread overview]
Message-ID: <83bfb7d2-655e-4f3d-9bda-3f275637a3f0@xiaomi.com> (raw)
In-Reply-To: <d5f1a318931b213f7a27de8441ba985354eecabb.1725334811.git.bo.wu@vivo.com>
On 2024/9/3 16:54, Wu Bo via Linux-f2fs-devel wrote:
Hi Bo,
>
> Set inline tail flag to enable this feature when new inode is created.
> Inherit the conditions from inline data.
>
> Signed-off-by: Wu Bo <bo.wu@vivo.com>
> ---
> fs/f2fs/namei.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
> index 38b4750475db..13c295ea19de 100644
> --- a/fs/f2fs/namei.c
> +++ b/fs/f2fs/namei.c
> @@ -315,6 +315,9 @@ static struct inode *f2fs_new_inode(struct mnt_idmap *idmap,
> /* Should enable inline_data after compression set */
> if (test_opt(sbi, INLINE_DATA) && f2fs_may_inline_data(inode))
> set_inode_flag(inode, FI_INLINE_DATA);
> + /* Inherit the conditions from inline data */
> + if (test_opt(sbi, INLINE_TAIL) && f2fs_has_inline_data(inode))
> + set_inode_flag(inode, FI_INLINE_TAIL);
Should f2fs_post_read_required() be checked here, like inline data?
Thanks,
Jianan
>
> if (name && !test_opt(sbi, DISABLE_EXT_IDENTIFY))
> set_file_temperature(sbi, inode, name);
> --
> 2.35.3
>
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2024-09-03 9:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 8:54 [PATCH 00/13] f2fs: introduce inline tail Wu Bo
2024-09-03 8:54 ` [PATCH 01/13] f2fs: add inline tail mount option Wu Bo
2024-09-03 8:54 ` [PATCH 02/13] f2fs: add inline tail disk layout definition Wu Bo
2024-09-03 8:54 ` [PATCH 03/13] f2fs: implement inline tail write & truncate Wu Bo
2024-09-03 8:54 ` [PATCH 04/13] f2fs: implement inline tail read & fiemap Wu Bo
2024-09-03 8:54 ` [PATCH 05/13] f2fs: set inline tail flag when create inode Wu Bo
2024-09-03 9:49 ` Huang Jianan [this message]
2024-09-03 9:50 ` [External Mail][f2fs-dev] " Huang Jianan
2024-09-04 3:03 ` [f2fs-dev] " Wu Bo
2024-09-03 8:54 ` [PATCH 06/13] f2fs: fix address info has been truncated Wu Bo
2024-09-03 8:54 ` [PATCH 07/13] f2fs: support seek for inline tail Wu Bo
2024-09-03 8:54 ` [PATCH 08/13] f2fs: convert inline tail when inode expand Wu Bo
2024-09-03 8:54 ` [PATCH 09/13] f2fs: fix data loss during inline tail writing Wu Bo
2024-09-03 8:54 ` [PATCH 10/13] f2fs: avoid inlining quota files Wu Bo
2024-09-03 8:54 ` [PATCH 11/13] f2fs: fix inline tail data lost Wu Bo
2024-09-03 8:54 ` [PATCH 12/13] f2fs: convert inline tails to avoid potential issues Wu Bo
2024-09-03 8:54 ` [PATCH 13/13] f2fs: implement inline tail forward recovery Wu Bo
2024-09-03 22:47 ` kernel test robot
2024-09-03 16:29 ` [f2fs-dev] [PATCH 00/13] f2fs: introduce inline tail Eric Biggers
2024-09-04 3:14 ` Wu Bo
2024-09-06 9:02 ` Juhyung Park
2024-09-06 10:57 ` Wu Bo
2024-09-06 14:52 ` Juhyung Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bfb7d2-655e-4f3d-9bda-3f275637a3f0@xiaomi.com \
--to=huangjianan@xiaomi.com \
--cc=bo.wu@vivo.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=wubo.oduw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®