From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53C2BC433DB for ; Tue, 5 Jan 2021 16:24:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2445922C9E for ; Tue, 5 Jan 2021 16:24:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728384AbhAEQYW (ORCPT ); Tue, 5 Jan 2021 11:24:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727036AbhAEQYV (ORCPT ); Tue, 5 Jan 2021 11:24:21 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A10FFC061793 for ; Tue, 5 Jan 2021 08:23:40 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id 3so93559wmg.4 for ; Tue, 05 Jan 2021 08:23:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Tk1Tgbf/mV84/2svjW1MlJGlo1p031I32QR/ghiBw58=; b=WqDdWO6eIcHv47qa/VLQ9pOYIIeDIqIXGl5G0xbXe+HB8oKT0SaMlbvKiz4vuQOW1U hwR8Xkdx440jH/2aeX2rYDKKE9RXddSzXW1S5lYCxp7HeoGZeiaJxdBlB4OhB+jLNMCY BE3pUsoIL11IfJb9K3GIYtn8Y3F10cGMv+QL6jgdcLKM7wT0uB/cCU9rU6CyUjl/thAB pMOBx/GRQlG1Ah/ESshYUIwBTEEQFBUWVpZNot52L3F29Zq0deDBhJNBYsK9I/TpPhQx S2Poa79QGo7xz2YCifhpBkqXh8shhqQBJylvyG27SDNRE8v/7eyqf+WntVCkabHG1wR9 TyAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Tk1Tgbf/mV84/2svjW1MlJGlo1p031I32QR/ghiBw58=; b=dTWrJqdX6qULsI9KAeUENqIc0rMct99zMkuupiSn6SuTS0uFMR5JKkSVL+zF5uM9U4 prYH4qZ0CWBmxbzpVJIsesql7FOzD/Kucu3TdTBd8X4olIQLeNTCq4f5hR2aO6uEXWRS Z6rHm6ou1aYnA+Q9w5yjhD2/8gRU5+DEEAKAlNrEy5+pNmNK60eYLHjHDO+QH5sGUVc2 u/Qfz11FF52v9pWZTVunt/FZNVXRxmq4/lTZ3wC3/unE61Fm0ZRuh4IHKcM/IWgHKV2i bURMNuGZH4QTJ8gS78WGI4hxN/e0+wuuMrgnIhvRDgNi5J82XX2gYbQqQ2AlDPGPlk1f CEkQ== X-Gm-Message-State: AOAM533vTO01dLwYP3oCd6hQpIImjJPDDEIeq8GGMHOUtt7iLeZScUuF h0dJOPjhoODnpee/NeiKCQS6cg== X-Google-Smtp-Source: ABdhPJy4Wcn1g0QPYCHFNxpcE3GkBZkWvVrFkBYHh9Uqc+ELoH00aG7SDclhPi8R5fXLaVz+z/N6bg== X-Received: by 2002:a1c:5459:: with SMTP id p25mr4006011wmi.19.1609863819467; Tue, 05 Jan 2021 08:23:39 -0800 (PST) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id m18sm350102wrw.43.2021.01.05.08.23.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Jan 2021 08:23:38 -0800 (PST) Subject: Re: [PATCH] nvmem: core: Fix a resource leak on error in nvmem_add_cells_from_of() To: Dan Carpenter Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: From: Srinivas Kandagatla Message-ID: <83c3536c-424a-46fb-5fdc-993b1bbb1490@linaro.org> Date: Tue, 5 Jan 2021 16:23:37 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/12/2020 10:55, Dan Carpenter wrote: > This doesn't call of_node_put() on the error path so it leads to a > memory leak. > > Fixes: 0749aa25af82 ("nvmem: core: fix regression in of_nvmem_cell_get()") > Signed-off-by: Dan Carpenter Applied, thanks --srini > --- > The kfree_const() could just be replaced with kfree(). Someone got over > excited converting things from kfree() to kfree_const(). > > drivers/nvmem/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index 177f5bf27c6d..68ae6f24b57f 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -713,6 +713,7 @@ static int nvmem_add_cells_from_of(struct nvmem_device *nvmem) > cell->name, nvmem->stride); > /* Cells already added will be freed later. */ > kfree_const(cell->name); > + of_node_put(cell->np); > kfree(cell); > return -EINVAL; > } >