From: Shardar Mohammed <smohammed@nvidia.com>
To: Laxman Dewangan <ldewangan@nvidia.com>,
Olliver Schinagl <oliver@schinagl.nl>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jslaby@suse.com>,
Stephen Warren <swarren@wwwdotorg.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] serial: tegra: Map the iir register to default defines
Date: Fri, 31 Mar 2017 10:07:15 +0000 [thread overview]
Message-ID: <83c51151685d4be7926f7f3982c59db8@bgmail102.nvidia.com> (raw)
In-Reply-To: <58DCDB54.5040005@nvidia.com>
Verification failed on Tegra.
Fix here is, IIR should be masked with UART_IIR_MASK after reading the IIR register as on Tegra bit-6 is used for internal usage to know if FIFO mode is enabled.
while (1) {
iir = tegra_uart_read(tup, UART_IIR);
+iir &= UART_IIR_MASK;
Thanks,
Shardar
-----Original Message-----
From: Laxman Dewangan
Sent: Thursday, March 30, 2017 3:48 PM
To: Olliver Schinagl <oliver@schinagl.nl>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Jiri Slaby <jslaby@suse.com>; Stephen Warren <swarren@wwwdotorg.org>; Thierry Reding <thierry.reding@gmail.com>; Alexandre Courbot <gnurou@gmail.com>
Cc: linux-serial@vger.kernel.org; linux-tegra@vger.kernel.org; linux-kernel@vger.kernel.org; Shardar Mohammed <smohammed@nvidia.com>
Subject: Re: [PATCH] serial: tegra: Map the iir register to default defines
On Thursday 30 March 2017 12:18 AM, Olliver Schinagl wrote:
> The tegra serial IP seems to be following the common layout and the
> interrupt ID's match up nicely. Replace the magic values to match the
> common serial_reg defines, with the addition of the Tegra unique End
> of Data interrupt.
>
> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
> ---
Adding Shardar for verifications.
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
next prev parent reply other threads:[~2017-03-31 10:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 18:48 Olliver Schinagl
2017-03-30 10:17 ` Laxman Dewangan
2017-03-31 10:07 ` Shardar Mohammed [this message]
2017-03-31 10:28 ` Jon Hunter
2017-03-31 10:42 ` Shardar Mohammed
2017-03-31 11:32 ` Olliver Schinagl
2017-03-30 13:42 ` Jon Hunter
2017-03-30 15:37 ` Olliver Schinagl
2017-03-31 13:21 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83c51151685d4be7926f7f3982c59db8@bgmail102.nvidia.com \
--to=smohammed@nvidia.com \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=oliver@schinagl.nl \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®