From: Sarthak Sharma <sarthak.sharma@arm.com>
To: Song Hu <husong@kylinos.cn>,
linux-mm@kvack.org, akpm@linux-foundation.org
Cc: shuah@kernel.org, david@kernel.org, ljs@kernel.org,
liam@infradead.org, vbabka@kernel.org, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, peterx@redhat.com,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] selftests/mm: emit TAP header and use TAP skip in mremap_test
Date: Fri, 14 Aug 2026 12:00:22 +0530 [thread overview]
Message-ID: <83c5375c-a374-4c51-b564-0b7ca4f4502d@arm.com> (raw)
In-Reply-To: <20260812120821.523860-3-husong@kylinos.cn>
Hi Song Hu!
On 8/12/26 5:38 PM, Song Hu wrote:
> mremap_test calls ksft_set_plan() without ksft_print_header(), and its
> get_mmap_min_addr() skip path uses a bare exit(KSFT_SKIP) that prints no
> TAP line, so its output is not valid KTAP. Add the header and switch the
> skip to ksft_exit_skip().
>
> Signed-off-by: Song Hu <husong@kylinos.cn>
> ---
While running the test, I saw that still some diagnostic lines are being
printed without being prefixed with a #. This is because of some prints
in the code of the format:
ksft_*("...\n\t...")
which is causing the part after the \n to not be prefixed with a #. If
you are planning for a respin, maybe you can include this in the same
patch so that the whole output becomes KTAP compliant :).
Rest of your changes look good. Once Sashiko's point on this patch has
been addressed, feel free to add
Reviewed-by: Sarthak Sharma <sarthak.sharma@arm.com>
next prev parent reply other threads:[~2026-08-14 6:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 12:08 [PATCH 0/3] selftests/mm: TAP output and global-state fixes Song Hu
2026-08-12 12:08 ` [PATCH 1/3] selftests/mm: emit TAP header in uffd-wp-mremap Song Hu
2026-08-12 13:42 ` Mike Rapoport
2026-08-14 6:13 ` Sarthak Sharma
2026-08-12 12:08 ` [PATCH 2/3] selftests/mm: emit TAP header and use TAP skip in mremap_test Song Hu
2026-08-12 13:42 ` Mike Rapoport
2026-08-14 6:30 ` Sarthak Sharma [this message]
2026-08-15 6:38 ` Song Hu
2026-08-12 12:08 ` [PATCH 3/3] selftests/mm: restore enable_soft_offline in hugetlb-soft-offline Song Hu
2026-08-12 13:42 ` Mike Rapoport
2026-08-15 6:35 ` Song Hu
2026-08-12 20:51 ` [PATCH 0/3] selftests/mm: TAP output and global-state fixes Andrew Morton
2026-08-15 6:40 ` Song Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83c5375c-a374-4c51-b564-0b7ca4f4502d@arm.com \
--to=sarthak.sharma@arm.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=husong@kylinos.cn \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®