From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B174C6778C for ; Tue, 3 Jul 2018 16:47:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C612F23C19 for ; Tue, 3 Jul 2018 16:47:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lechnology.com header.i=@lechnology.com header.b="Qx/Ds5z6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C612F23C19 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lechnology.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934092AbeGCQrZ (ORCPT ); Tue, 3 Jul 2018 12:47:25 -0400 Received: from vern.gendns.com ([206.190.152.46]:37003 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932759AbeGCQrX (ORCPT ); Tue, 3 Jul 2018 12:47:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lechnology.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dZ0tuJT+8sRAPhUeMcO/8RQYnUkZQeN1qjmAE9fKA7Y=; b=Qx/Ds5z6Us9IMmlp6DpuXStH6w 79aHwzR86Qh2aF0vOMKGStOSuUfZJDpoXGEoPu+8IGhiv3fydHzV6PGZytjAe+OM5K7ivRjA+7NaW B19THACU7S9Q1u0OlmHYuhSl6+nzehruAiWKmZ/0uCjTuRoo9sDjzLq4kFL5CnhdXTBmVyXGcpT+u foIp6X/yNXBfK7t2bRBhy9/LqHkGY85oPVEBIZ651hq/iWh3Nz3fw0dtTmDyWxNATJFXAHK8Cv7EW 27nPZqCZ9jXFksZy3BIhzN7gSe/X3RLPNz50yFFgp8LIwMcp0T/HVV+ZL/ZiDK7dHkjoBDisk73Ai e/9p9i/w==; Received: from 108-198-5-147.lightspeed.okcbok.sbcglobal.net ([108.198.5.147]:58838 helo=[192.168.0.134]) by vern.gendns.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1faOSU-00HTG6-Sq; Tue, 03 Jul 2018 12:47:19 -0400 Subject: Re: [PATCH v4 08/18] net: davinci_emac: potentially get the MAC address from MTD To: Florian Fainelli , Bartosz Golaszewski , Sekhar Nori , Kevin Hilman , Russell King , Grygorii Strashko , "David S . Miller" , Srinivas Kandagatla , Lukas Wunner , Rob Herring , Dan Carpenter , Ivan Khoronzhuk , Greg Kroah-Hartman , Andrew Lunn , Jonathan Corbet Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, netdev@vger.kernel.org, Bartosz Golaszewski References: <20180629094039.7543-1-brgl@bgdev.pl> <20180629094039.7543-9-brgl@bgdev.pl> <03b77e24-9ab9-fa01-2387-9de0408a9942@gmail.com> From: David Lechner Message-ID: <83c551d9-9e66-fc72-7f8d-c43337d05a71@lechnology.com> Date: Tue, 3 Jul 2018 11:47:16 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <03b77e24-9ab9-fa01-2387-9de0408a9942@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/03/2018 11:39 AM, Florian Fainelli wrote: > > > On 06/29/2018 02:40 AM, Bartosz Golaszewski wrote: >> From: Bartosz Golaszewski >> >> On da850-evm board we can read the MAC address from MTD. It's currently >> done in the relevant board file, but we want to get rid of all the MAC >> reading callbacks from the board file (SPI and NAND). Move the reading >> of the MAC address from SPI to the emac driver's probe function. > > This should be made something generic to all drivers, not just something > the davinci_emac driver does, something like this actually: > > https://lkml.org/lkml/2018/3/24/312 > I was thinking about suggesting adding a nvmem provider for MTD devices as well. It would fix the kernel config dependency problems I was running into since nvmem lookups can do -EPROBE_DEFER.