From: "Arnd Bergmann" <arnd@kernel.org>
To: "Ian Abbott" <abbotti@mev.co.uk>, linux-kernel@vger.kernel.org
Cc: "Niklas Schnelle" <schnelle@linux.ibm.com>
Subject: Re: [PATCH 09/13] comedi: ni_mio_common: Conditionally use I/O port or MMIO
Date: Wed, 13 Sep 2023 20:01:40 +0200 [thread overview]
Message-ID: <83c58cdc-b96a-40c3-bed1-767e9e832893@app.fastmail.com> (raw)
In-Reply-To: <79be8582-2395-42c7-92ae-29d9e4c4c33b@mev.co.uk>
On Wed, Sep 13, 2023, at 17:45, Ian Abbott wrote:
> On 13/09/2023 13:17, Arnd Bergmann wrote:
>> On Wed, Sep 13, 2023, at 13:20, Ian Abbott wrote:
>>>
>>> The changes make it possible to build the ni_pcimio module even if the
>>> port I/O functions have not been declared. (The ni_atmio and ni_mio_cs
>>> modules do still require the port I/O functions to be declared.)
>>
>> I think this all works, but there is probably a simpler way to
>> achieve the same:
>>
>>> +#ifdef PCIDMA
>>> +
>>> static void ni_writel(struct comedi_device *dev, unsigned int data, int reg)
>>> {
>>> - if (dev->mmio)
>>> - writel(data, dev->mmio + reg);
>>> - else
>>> - outl(data, dev->iobase + reg);
>>> + writel(data, dev->mmio + reg);
>>> }
>>>
>>>
>>> +#else /* PCIDMA */
>>> +
>>> +static void ni_writel(struct comedi_device *dev, unsigned int data, int reg)
>>> +{
>>> + outl(data, dev->iobase + reg);
>>> +}
>>
>> We already have an abstraction for this using iowrite32(),
>> which turns into either writel() or outl() depending on the
>> argument, so you could just use pci_iomap() or ioport_map()
>> to turn port numbers into tokens suitable for the common
>> helper.
>
> It would affect three modules, and there are similar changes that could
> be made to other modules, so I think I'll put that suggestion on hold
> for now. I'd also like to get rid of the '#include "ni_mio_common.c"'
> nonsense at some point, but that's a big job!
Sure, that's fine, I just thought I'd mention it in case you
were looking for a nicer implementation. I wouldn't have done
the current series to start with since there is not a huge amount
of value in running these drivers on obscure architectures
without HAS_IOPORT, but your changes are otherwise completely
sensible.
Arnd
next prev parent reply other threads:[~2023-09-13 18:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 11:20 [PATCH 00/13] comedi: Re-do HAS_IOPORT dependencies Ian Abbott
2023-09-13 11:20 ` [PATCH 01/13] comedi: Correct dependencies for COMEDI_NI_PCIDIO Ian Abbott
2023-09-13 11:20 ` [PATCH 02/13] comedi: comedi_8254: Use a call-back function for register access Ian Abbott
2023-09-13 11:20 ` [PATCH 03/13] comedi: comedi_8254: Replace comedi_8254_init() and comedi_8254_mm_init() Ian Abbott
2023-09-13 11:20 ` [PATCH 04/13] comedi: comedi_8254: Conditionally remove I/O port support Ian Abbott
2023-09-13 11:20 ` [PATCH 05/13] comedi: 8255_pci: Conditionally remove devices that use port I/O Ian Abbott
2023-09-13 12:03 ` Arnd Bergmann
2023-09-13 15:04 ` Ian Abbott
2023-09-13 11:20 ` [PATCH 06/13] comedi: comedi_8255: Rework subdevice initialization functions Ian Abbott
2023-09-13 11:20 ` [PATCH 07/13] comedi: comedi_8255: Conditionally remove I/O port support Ian Abbott
2023-09-13 11:20 ` [PATCH 08/13] comedi: ni_labpc_common: " Ian Abbott
2023-09-13 11:20 ` [PATCH 09/13] comedi: ni_mio_common: Conditionally use I/O port or MMIO Ian Abbott
2023-09-13 12:17 ` Arnd Bergmann
2023-09-13 15:45 ` Ian Abbott
2023-09-13 18:01 ` Arnd Bergmann [this message]
2023-09-13 11:20 ` [PATCH 10/13] comedi: amplc_dio200_pci: Conditionally remove devices that use port I/O Ian Abbott
2023-09-13 11:20 ` [PATCH 11/13] comedi: amplc_dio200_common: Refactor register access functions Ian Abbott
2023-09-13 11:20 ` [PATCH 12/13] comedi: amplc_dio200_common: Conditionally remove I/O port support Ian Abbott
2023-09-13 11:20 ` [PATCH 13/13] comedi: add HAS_IOPORT dependencies again Ian Abbott
2023-09-13 11:26 ` [PATCH 00/13] comedi: Re-do HAS_IOPORT dependencies Ian Abbott
2023-09-13 11:32 Ian Abbott
2023-09-13 11:32 ` [PATCH 09/13] comedi: ni_mio_common: Conditionally use I/O port or MMIO Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83c58cdc-b96a-40c3-bed1-767e9e832893@app.fastmail.com \
--to=arnd@kernel.org \
--cc=abbotti@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®