From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 139FD37C11E for ; Wed, 29 Apr 2026 17:02:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777482171; cv=none; b=SoTEzeQjJZsiSIhcWgJBUdhVYYxWxG5sQ25uSxoFHuUO6wozGnlt7nkoJlHgpFdWOHoYlH26fpMej4pnZOLUhyAV5K3GtBtZfxoNbC3UawzLob70M5AOAjWrerESu6AQG2gmK5Zr6ykTaJPKyfkM1KUQ9hnkIhwpBY7NAc5OpPE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777482171; c=relaxed/simple; bh=oP0CV+puQtnqAudPjWQ6eG2kcGlvGEf4j8WHFrP4gG4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YgpxMTslAKRu+EsIUdQRdKTqn3GCqO9oH4BDkKCYehA3K0nOmyudbWWNuwTgrmQxv/elP19MicU5j9O+86BzUMbEwxRkA969Q0tD8QuUPkk/Yjy0cFzmyZ7ynu+aRavVjH0y7/e/WtXBOI3MP99nGZ1lGcO8JpLGSj4b+bYIIZs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=M8ZDn9J8; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="M8ZDn9J8" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-488b0046078so115811945e9.1 for ; Wed, 29 Apr 2026 10:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777482168; x=1778086968; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0DSk2ikmD/TKHxP326DjLJj6TQaKaQdWjt46lW8P0oM=; b=M8ZDn9J8Msr3NDylCnVIxwOwQz08PjGveWyRb7/XjqkWB5UDx082NPsg34OU9g6aPJ TqcQJpVTaakQuUf9Y2g6yj5Isf7op9kV6MbFG6wACZofFn8TMj35e5KyPoSFl5pwuuQH 6sBItpme8djYXD0GoY5kYPmKOhFpbKCPS4EJ17m5wVjlZBSMk+CDzN8c5Zr0jz5tJdkS u9taszG5vc0LCQ2EzpSe3MoyXYj0Uv4DSNEEmOVtt5oJTf1jy6mfnPWkvb/UkjmGs/D1 NN3BAwVUlMXWaxesZAR6VG/PGwIDyqYgC2PevACW14bE7u61kuE0DbDN5FruguT3Y4Zz Mqjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777482168; x=1778086968; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0DSk2ikmD/TKHxP326DjLJj6TQaKaQdWjt46lW8P0oM=; b=EmaUDTtCr1ktgHyippMxWdF9mcShPmjDGmAaCpK8e7Xks7RSFJQwtxqbXlFRlPu1rV RMllCza76Hq3kFSkv0Mow6sNk+EaLm6dIYfZtfx5uAwgiCcsULkm1DnlhOXI6uZEClt0 SX+xIdNB8WQjXXYKz0L7fsA7wUegfg5Sb9PyfYRidWih3QluJNkL/MO8Q6KmrLuT0uT+ L0IAvPAyb/SZj7+Frfbe73PlSG9DjjIqYpzH6TUr/6wTWBM6Z1xsphyMECDNsWFyM4ha t4xmOvwsAE8hrntnVtRB5+3rFPp9+LPRkMSRxah3L3AQo8+sKABUMiUmt8fd2T0qd69T FOKg== X-Forwarded-Encrypted: i=1; AFNElJ+FBEVL3IzvKQ5a+nKsJ/HGX/nJrz9MIfO5mRne8Ihv1bfN68Nmbc0Q9Whi4P9UAV1ixtOm/Hb4PUKz10Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yzn/Q8e3bVLC/2X60HrCosEvwYlevR8BK/Loa1wKfmqCs5v+C7T fJZFucij/64UICaeG7oAFXZ1XMU0h9PySr4nO9xI1REZFmof0fiGacc4bVZL+wTuZyo= X-Gm-Gg: AeBDiev4loU66v2nc83KEvGfluk5jmaViM5YG912UJd9g46VNhJ7ID5TEhZKiLV0xTx HlSL8a+l2bUzOraV67cxMlzqg6QGvqiHu1QGGQ0dEuGZ+YB68srWCnpXIJAP4uK/ShSP2qLA+T/ Mx+6XC2RcpxxC3cYOhHWsNg0KY4/g45UXsDxXSMod1AvY/IMJuHxEFQT1lajKtFkR9l9NLrg+m3 IP26KdQPiWQxCzchk5b/oH3uUNegLX+eVbUgKVgjUK5Zeh8+Xw89DJKmGsxykJS/bAm+q8nC5Te oI9w1VG4xUYskjIc4/3muVUysFtDeUgYt4BNpZeetxDQ6hbYnL6I8pDem45WRfxe6thyUFoLEZF zY8vjM2c5awai2bEnEWlP7KA+pAMol7M1SzSGIrUc6+MaU9yYd3O6jLDmba2FfMrRKRweCS0qBt gpMGHoNup6IDNdj5GIJS1kzFO1K8rfN1IarP3PwHY2Zso= X-Received: by 2002:a05:600c:4f0c:b0:489:1c2d:211e with SMTP id 5b1f17b1804b1-48a77ae5386mr141380935e9.5.1777482168330; Wed, 29 Apr 2026 10:02:48 -0700 (PDT) Received: from [10.11.12.108] ([79.115.63.228]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-447b3d481fdsm7255405f8f.8.2026.04.29.10.02.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2026 10:02:47 -0700 (PDT) Message-ID: <83c64dc4-6dd8-4edb-8acf-3c731048d73d@linaro.org> Date: Wed, 29 Apr 2026 20:02:44 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 02/11] firmware: samsung: acpm: Consolidate transfer initialization helper To: Krzysztof Kozlowski , "Rafael J. Wysocki" , Zhang Rui , Lukasz Luba , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Bartlomiej Zolnierkiewicz , Kees Cook , "Gustavo A. R. Silva" , Peter Griffin , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Daniel Lezcano , Sylwester Nawrocki , Chanwoo Choi , Michael Turquette , Stephen Boyd , Lee Jones Cc: willmcvicker@google.com, jyescas@google.com, shin.son@samsung.com, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hardening@vger.kernel.org, linux-clk@vger.kernel.org References: <20260423-acpm-tmu-v4-0-8b59f8548634@linaro.org> <20260423-acpm-tmu-v4-2-8b59f8548634@linaro.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/28/26 12:25 PM, Krzysztof Kozlowski wrote: > On 23/04/2026 17:22, Tudor Ambarus wrote: >> acpm_dvfs_init_get_rate_cmd(cmd, clk_id); >> - acpm_dvfs_set_xfer(&xfer, cmd, ARRAY_SIZE(cmd), acpm_chan_id, true); >> + acpm_set_xfer(&xfer, cmd, ARRAY_SIZE(cmd), acpm_chan_id, true); >> >> ret = acpm_do_xfer(handle, &xfer); >> if (ret) >> diff --git a/drivers/firmware/samsung/exynos-acpm-pmic.c b/drivers/firmware/samsung/exynos-acpm-pmic.c >> index 0c50993cc9a8..f032f2c69685 100644 >> --- a/drivers/firmware/samsung/exynos-acpm-pmic.c >> +++ b/drivers/firmware/samsung/exynos-acpm-pmic.c >> @@ -58,16 +58,6 @@ static inline u32 acpm_pmic_get_bulk(u32 data, unsigned int i) >> return (data >> (ACPM_PMIC_BULK_SHIFT * i)) & ACPM_PMIC_BULK_MASK; >> } >> >> -static void acpm_pmic_set_xfer(struct acpm_xfer *xfer, u32 *cmd, size_t cmdlen, >> - unsigned int acpm_chan_id) >> -{ >> - xfer->txd = cmd; >> - xfer->rxd = cmd; >> - xfer->txcnt = cmdlen; >> - xfer->rxcnt = cmdlen; >> - xfer->acpm_chan_id = acpm_chan_id; > > The code is not equivalent. RX bits were always cleared. This should be > explained in the commit msg which would also provide a proof that you > actually analyzed if it has any impact. > Indeed, my commit message is inaccurate because I claimed the acpm_pmic/dvfs_set_xfer() were identical. There's no change in functionality: in the original `acpm_pmic_set_xfer()`, the RX parameters were unconditionally assigned (`xfer->rxd = cmd;` and `xfer->rxcnt = cmdlen;`). In this patch, all the updated PMIC call sites now pass `true` for the `response` argument. This ensures the unified helper takes the `if (response)` branch, which performs those exact same assignments, preserving the original PMIC behavior. Will update the commit message. And revisit the other patches when splitting the firmware patches into their own set. Thanks, ta