From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 052D2C64E7A for ; Tue, 1 Dec 2020 19:43:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9EB82221E2 for ; Tue, 1 Dec 2020 19:43:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390096AbgLATnF (ORCPT ); Tue, 1 Dec 2020 14:43:05 -0500 Received: from smtprelay0079.hostedemail.com ([216.40.44.79]:52698 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726213AbgLATnF (ORCPT ); Tue, 1 Dec 2020 14:43:05 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id ECC8F182CED28; Tue, 1 Dec 2020 19:42:23 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: magic08_1c06533273ad X-Filterd-Recvd-Size: 2218 Received: from XPS-9350.home (unknown [47.151.128.180]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Tue, 1 Dec 2020 19:42:22 +0000 (UTC) Message-ID: <83c7170c7ce6195dc73dcf813965c3e4a99fa4ed.camel@perches.com> Subject: Re: [PATCH 3/3] firmware: xilinx: Properly align function parameter From: Joe Perches To: Michal Simek , linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com Cc: Greg Kroah-Hartman , Jolly Shah , Rajan Vaja , Tejas Patel , linux-arm-kernel@lists.infradead.org Date: Tue, 01 Dec 2020 11:42:21 -0800 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-12-01 at 16:50 +0100, Michal Simek wrote: > Fix parameters alignment reported by checkpatch --strict. Please use a newer checkpatch as the 80 column warning isn't enforced quite the same way. > diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h [] > @@ -456,7 +456,8 @@ static inline int zynqmp_pm_sd_dll_reset(u32 node_id, u32 type) >  } >   > >  static inline int zynqmp_pm_reset_assert(const enum zynqmp_pm_reset reset, > - const enum zynqmp_pm_reset_action assert_flag) > + const enum zynqmp_pm_reset_action > + assert_flag) I think these changes aren't very good as it separates the type from the variable name. > @@ -490,9 +491,10 @@ static inline int zynqmp_pm_release_node(const u32 node) >  } >   > >  static inline int zynqmp_pm_set_requirement(const u32 node, > - const u32 capabilities, > - const u32 qos, > - const enum zynqmp_pm_request_ack ack) > + const u32 capabilities, > + const u32 qos, > + const enum zynqmp_pm_request_ack > + ack)