From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97C29C433F5 for ; Mon, 28 Mar 2022 01:16:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236187AbiC1BS0 (ORCPT ); Sun, 27 Mar 2022 21:18:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229812AbiC1BSZ (ORCPT ); Sun, 27 Mar 2022 21:18:25 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CA194EF78; Sun, 27 Mar 2022 18:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648430206; x=1679966206; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=xidA2y8NjDEx3Ibl8t+vOISEY3MuUuhbC36nv/l+7VU=; b=EbltWSu9D9qNNVIEO2FuLRPSTLKUZ0uJJSo50Pgg2PcjKQuU8+AWa1Ku IG0Y/q8XmE6LWuBoZQIClsqyiI+CbskUj70tc0CIhptEVhYkTl9LTrRDq dhzfP32LmZqwFwC6oAbXHQDD7M9qwK07qGquUt4DcpMAnqsMhXAH1PltG 0ZMBQN5+JOfwqC7C35z14kkgZMOY8FiX7ElLnSZtAsdo3mS0g0rpGDTAP iEHt3jRvYHn1EXhoNlZQPuFD6x2Q4mY1eCoLOHD6yDWBm95fLjcm96kON CT2M2nicFH864QZkKvgMGC9OF67jF5YwchH4sTZ2JhrAjWYTy4afIqpl7 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10299"; a="241041411" X-IronPort-AV: E=Sophos;i="5.90,216,1643702400"; d="scan'208";a="241041411" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2022 18:16:45 -0700 X-IronPort-AV: E=Sophos;i="5.90,216,1643702400"; d="scan'208";a="651388422" Received: from stung2-mobl.gar.corp.intel.com (HELO khuang2-desk.gar.corp.intel.com) ([10.255.94.73]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2022 18:16:42 -0700 Message-ID: <83ccfde2f88b9be9eed40784ac22617dd0d69a33.camel@intel.com> Subject: Re: [PATCH v2 13/21] x86/virt/tdx: Allocate and set up PAMTs for TDMRs From: Kai Huang To: Isaku Yamahata Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, dave.hansen@intel.com, seanjc@google.com, pbonzini@redhat.com, kirill.shutemov@linux.intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, peterz@infradead.org, tony.luck@intel.com, ak@linux.intel.com, dan.j.williams@intel.com, isaku.yamahata@intel.com Date: Mon, 28 Mar 2022 14:16:40 +1300 In-Reply-To: <20220324180648.GB1212881@ls.amr.corp.intel.com> References: <20220324180648.GB1212881@ls.amr.corp.intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2022-03-24 at 11:06 -0700, Isaku Yamahata wrote: > On Sun, Mar 13, 2022 at 11:49:53PM +1300, > Kai Huang wrote: > > > diff --git a/arch/x86/virt/vmx/tdx.c b/arch/x86/virt/vmx/tdx.c > > index 1939b64d23e8..c58c99b94c72 100644 > > --- a/arch/x86/virt/vmx/tdx.c > > +++ b/arch/x86/virt/vmx/tdx.c > > @@ -21,6 +21,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include "tdx.h" > > > > @@ -66,6 +67,16 @@ > > #define TDMR_START(_tdmr) ((_tdmr)->base) > > #define TDMR_END(_tdmr) ((_tdmr)->base + (_tdmr)->size) > > > > +/* Page sizes supported by TDX */ > > +enum tdx_page_sz { > > + TDX_PG_4K = 0, > > + TDX_PG_2M, > > + TDX_PG_1G, > > + TDX_PG_MAX, > > +}; > > + > > +#define TDX_HPAGE_SHIFT 9 > > + > > /* > > * TDX module status during initialization > > */ > > @@ -893,7 +904,7 @@ static int create_tdmrs(struct tdmr_info **tdmr_array, int *tdmr_num) > > * them. To keep it simple, always try to use one TDMR to cover > > * one RAM entry. > > */ > > - e820_for_each_mem(e820_table, i, start, end) { > > + e820_for_each_mem(i, start, end) { > > This patch doesn't change e820_for_each_mem. This hunk should go into the > previous patch? > > thansk, > Exactly. My mistake. Thanks for catching. -- Thanks, -Kai