From: "Li, Zhijian" <lizhijian@fujitsu.com>
To: Yanjun Zhu <yanjun.zhu@linux.dev>, Jason Gunthorpe <jgg@ziepe.ca>,
"Haakon Bugge" <haakon.bugge@oracle.com>,
Cheng Xu <chengyou@linux.alibaba.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"Yang, Xiao" <yangx.jy@fujitsu.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/2] RDMA/rxe: Fix no completion event issue
Date: Sun, 26 Jun 2022 11:29:53 +0800 [thread overview]
Message-ID: <83cfdf23-7a2d-0776-85ee-7314187e9980@fujitsu.com> (raw)
In-Reply-To: <3ee9e8d1-01dc-0936-efde-b07482a5e785@linux.dev>
on 6/25/2022 8:59 PM, Yanjun Zhu wrote:
>
> 在 2022/6/7 16:32, lizhijian@fujitsu.com 写道:
>> Hi Json & Yanjun
>>
>>
>> I know there are still a few regressions on RXE, but i do wish you
>> could take some time to review these *simple and bugfix* patches
>> They are not related to the regressions.
>
> Now there are some problems from Redhat and other Linux Vendors.
>
> We had better focus on these problems.
+ Xiao
I do believe regression is high priority, and I'm very willing to contribute our efforts to improve the stability of RXE :)
Yang,Xiao and me tried to reproduce the issues in maillist and we also tried to review the their corresponding patches.
However actually we didn't find a unified way something like bugzilla to maintain the issues and their status, and most of
them are not reproduced by our local environment. So it's a bit hard for us to review/verify the patches especially for the
large/complicate patch if we don't have the use cases.
BTW, IMO we shouldn't stop reviewing other fixes expect recent regressions.
Zhijian
>
> Zhu Yanjun
>
>>
>>
>> Thanks
>> Zhijian
>>
>>
>> On 16/05/2022 09:53, Li Zhijian wrote:
>>> Since RXE always posts RDMA_WRITE successfully, it's observed that
>>> no more completion occurs after a few incorrect posts. Actually, it
>>> will block the polling. we can easily reproduce it by the below
>>> pattern.
>>>
>>> a. post correct RDMA_WRITE
>>> b. poll completion event
>>> while true {
>>> c. post incorrect RDMA_WRITE(wrong rkey for example)
>>> d. poll completion event <<<< block after 2 incorrect RDMA_WRITE
>>> posts
>>> }
>>>
>>>
>>> Li Zhijian (2):
>>> RDMA/rxe: Update wqe_index for each wqe error completion
>>> RDMA/rxe: Generate error completion for error requester QP state
>>>
>>> drivers/infiniband/sw/rxe/rxe_req.c | 12 +++++++++++-
>>> 1 file changed, 11 insertions(+), 1 deletion(-)
>>>
next prev parent reply other threads:[~2022-06-26 3:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 1:53 Li Zhijian
2022-05-16 1:53 ` [PATCH v3 1/2] RDMA/rxe: Update wqe_index for each wqe error completion Li Zhijian
2022-06-26 21:51 ` Bob Pearson
2022-06-27 3:41 ` lizhijian
2022-05-16 1:53 ` [PATCH v3 2/2] RDMA/rxe: Generate error completion for error requester QP state Li Zhijian
2022-06-26 22:42 ` Bob Pearson
2022-06-07 8:32 ` [PATCH v3 0/2] RDMA/rxe: Fix no completion event issue lizhijian
2022-06-24 23:39 ` Jason Gunthorpe
2022-06-25 7:47 ` Li, Zhijian
2022-06-25 12:59 ` Yanjun Zhu
2022-06-26 3:29 ` Li, Zhijian [this message]
2022-06-26 10:38 ` yangx.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83cfdf23-7a2d-0776-85ee-7314187e9980@fujitsu.com \
--to=lizhijian@fujitsu.com \
--cc=chengyou@linux.alibaba.com \
--cc=haakon.bugge@oracle.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yangx.jy@fujitsu.com \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®