From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dave Penkler <dpenkler@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Marcello Carla' <marcello.carla@gmx.com>
Subject: Re: [PATCH 3/4] staging: gpib: Fix erroneous removal of blank before newline
Date: Wed, 4 Dec 2024 19:05:42 +0300 [thread overview]
Message-ID: <83d08acd-3195-41a0-9708-ad17aaa15b5d@stanley.mountain> (raw)
In-Reply-To: <20241204145713.11889-4-dpenkler@gmail.com>
You're going to need to resend this. Run checkpatch.pl etc.
On Wed, Dec 04, 2024 at 03:57:12PM +0100, Dave Penkler wrote:
> Replace original blanks with "."
>
Take a look at how this look like on lore:
https://lore.kernel.org/all/20241204145713.11889-4-dpenkler@gmail.com/
The subject is hard to see. It's better to think of it as the title
instead of the first sentence.
To be honest, I don't really understand this commit. Presumably this
gets printed out or something? Can you cut a paste a few lines of
before and after text to show us how it looks like?
regards,
dan carpenter
next prev parent reply other threads:[~2024-12-04 16:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 14:57 [PATCH 0/4] staging: gpib: Cleanup and fixes for lpvo driver Dave Penkler
2024-12-04 14:57 ` [PATCH 1/4] staging: gpib: Remove useless include Dave Penkler
2024-12-04 14:57 ` [PATCH 2/4] staging: gpib: Remove duplicate include Dave Penkler
2024-12-04 14:57 ` [PATCH 3/4] staging: gpib: Fix erroneous removal of blank before newline Dave Penkler
2024-12-04 15:29 ` Greg KH
2024-12-04 16:05 ` Dan Carpenter [this message]
2024-12-04 14:57 ` [PATCH 4/4] staging: gpib: Fix faulty workaround for assignment in if Dave Penkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d08acd-3195-41a0-9708-ad17aaa15b5d@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcello.carla@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®