From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E00E2EB1F for ; Thu, 5 Dec 2024 17:43:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733420582; cv=none; b=TwIDT0lym3PGS1UPRxrB9mq30pCNMSgs4iEQ4hstO8fgnFsCj0B/TYjohChQeq8elTpGNSvsI8E3aEJOEIP0jibwOj+76tkoupEPuTKwO5cC80tC9/+ivg/BDa1XCjFS/LsKbUTWkdDI26shIT7p+t2XAIQX7C9ua7u6jjDUkyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733420582; c=relaxed/simple; bh=83LLzNzqiW7Cv7hs/AaVSW4+DKsidQGfdG7Ia9j+bnc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kXtZoFSTlTTtV/Rcq7U2cSFVy1rrqi8Gfm+bAj6IA6CgC+WvO0PhyNdakeMzj9j8n9SMimrY869D5bxAFbaSt1G2DK8I+fpZglST0v5wOmhonvDUIYKCZjoY1/Pv5fAW9pwwc+f4V4kOfjvc8sOzR/lNQbt3h81f9eTdi5vqxCU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I6Fm9oz4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I6Fm9oz4" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4B5HaNBJ031095 for ; Thu, 5 Dec 2024 17:43:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hx57Lu41ib8MxOqYtwF0SnxIqxAgV7Fue5Y4OtnFhH8=; b=I6Fm9oz4a1EJ7ENG PsbiW0IRJMvanLT1b9O8hYQ4fjnKE5m5MnpbeVEjgveE9lo/7NOchAiXMv+8Iu4K i7iWuzZ582HcXBmKdY/07iKVFf+bgv5DVpRHBEcdH/1TSGMVRk750D3jtEOHEeHf 9e6HAOEat3PO6YoEwX1HoDEZs7JRj/FUuezoSRSLIEPka8mHcrNP3u8ulxkVDpZL 83ErgxQFuDcEdaTCVMHd0lzTbLaleatr+fK+J29Dgg9wWyhNa0WmVUzC2NpADBeF sh2xeVw8yQSBe7m3xmDGcLDXSUWtecJPRnLBgXqG9MUi4GGeNZ36p9ydt9paBbak bnBO3g== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43be170j76-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 05 Dec 2024 17:43:00 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7b66e2b7287so3271485a.2 for ; Thu, 05 Dec 2024 09:43:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733420579; x=1734025379; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hx57Lu41ib8MxOqYtwF0SnxIqxAgV7Fue5Y4OtnFhH8=; b=attihy4RNLsDztQ3m/U2jQRSObKfbqDNrSM6+PVHh53zfigPZV1fGoEGUyXs22SwXk WTiPbcBdKTPHD6P20i8x0/UbpP7UTH6pf7m/ni0KTUf1TNnZEP+Qc5Ox/8S9TZcj5I0Z ORWnRzo+HjLlrpX8cl6PwsGOPoDQZzPZiBNbYPv6UbjqaYUgdGVV0oRBikdRuvY2XEcm Ia0GdY5QAii94qzpMOCjPcopIv23dFeJA45UvqzsfbDXIK2tNuMPc3oknNv/9qnXIGDV crMq24M2sxigJR+fRqWaLcqdZ1SiamF791SiIG03BLa5KmUYu1vUxi219C5o8VUcgZd1 LbJA== X-Forwarded-Encrypted: i=1; AJvYcCX7o/go4+Ae/2XfhTkFFillVh7yp4Q/vGF2bYpGOMzeNOCQv1T6h7xTeO4es/TqkQQshnC6LCTSoliH7zU=@vger.kernel.org X-Gm-Message-State: AOJu0YxVsnIIk4qmGsYW+9crp3oGRI0WTUzuOL64tz4ol0DPfdsGwQfk N9l9vbu2ivUalpCW3VOTiXM0HQ8sb5UsaljYwFoDc7cBY6Gvhc9vtUPbAHLytSHiTNtMZOvfkfa McWbNMcY/MUmMJEBj9T0+kJRRVJcqsrWpEK4RM0x09+uCoVUWKDmIyr/HlK6bCuo= X-Gm-Gg: ASbGncuUpKDz4BpWzF1QCy/Hb4hx5wAas9WndtkoVGdbcKfqfL73GTUYBbiDp8/NQ3P eNyAPaHzqBLS9nl7M9VpkBDNYZeMgmstI6cY0te2Bn3XYNSfbmpwE51i9Mcz6idVg2788KAkAFS TrSRWJmHsWFY9PLRNyaFUG0UDs+st4Is8/zqO1paoNM33XE1lAnJyqX00OBDfJ1BgQzv8UM0ueV KkDR9YLMm+eiU/JIM/pdOpcr9N85GKuD4iL5xWbf0YdO+Ni1Z8FGs+BBMOLzTWcrDTsnPjv/5vb 2KmkMSl/EGf4X2YbwjtzaLf1GnQ5H9s= X-Received: by 2002:a05:620a:2a0a:b0:7b1:3bf8:b3c4 with SMTP id af79cd13be357-7b6bca1437cmr6492685a.0.1733420579468; Thu, 05 Dec 2024 09:42:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IGqTIBVAUtYMFwIH7nMUAnsmsAxJGz+whkQJCNEPVEIPV7Fzd+DE/MjzrxB52NAzHD9Q0SRpg== X-Received: by 2002:a05:620a:2a0a:b0:7b1:3bf8:b3c4 with SMTP id af79cd13be357-7b6bca1437cmr6491285a.0.1733420579088; Thu, 05 Dec 2024 09:42:59 -0800 (PST) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa625e4dbf3sm121879066b.12.2024.12.05.09.42.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Dec 2024 09:42:58 -0800 (PST) Message-ID: <83d216c4-bf9e-4eb4-86d3-e189602f37cc@oss.qualcomm.com> Date: Thu, 5 Dec 2024 18:42:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 15/22] wifi: ath12k: add BDF address in hardware parameter To: Raj Kumar Bhagat , Konrad Dybcio , ath12k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Kalle Valo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jeff Johnson , Bjorn Andersson , Konrad Dybcio , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20241015182637.955753-1-quic_rajkbhag@quicinc.com> <20241015182637.955753-16-quic_rajkbhag@quicinc.com> <142f92d7-72e1-433b-948d-2c7e7d37ecfc@oss.qualcomm.com> <0796510c-20bd-4a81-bd60-40aacbcf61c0@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <0796510c-20bd-4a81-bd60-40aacbcf61c0@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: erkQCEOCny4BDYlpGUlw7z2Ryc7YzbSo X-Proofpoint-ORIG-GUID: erkQCEOCny4BDYlpGUlw7z2Ryc7YzbSo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 spamscore=0 bulkscore=0 priorityscore=1501 mlxscore=0 impostorscore=0 suspectscore=0 adultscore=0 malwarescore=0 clxscore=1015 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412050130 On 3.12.2024 10:18 AM, Raj Kumar Bhagat wrote: > On 11/4/2024 7:46 PM, Konrad Dybcio wrote: >> On 15.10.2024 8:26 PM, Raj Kumar Bhagat wrote: >>> The Ath2k AHB device (IPQ5332) firmware requests BDF_MEM_REGION_TYPE >>> memory during QMI memory requests. This memory is part of the >>> HOST_DDR_REGION_TYPE. Therefore, add the BDF memory address to the >>> hardware parameter and provide this memory address to the firmware >>> during QMI memory requests. >> >> Sounds like something to put in the device tree, no? >> > > This BDF memory address is the RAM offset. We did add this in device tree in > version 1. This is removed from device tree in v2 based on the review comment that > DT should not store RAM offset. > > refer below link: > Link: https://lore.kernel.org/all/f8cd9c3d-47e1-4709-9334-78e4790acef0@kernel.org/ Right, I think this could be something under /reserved-memory instead Konrad