From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1DD7EB64DD for ; Fri, 14 Jul 2023 03:17:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234809AbjGNDRN (ORCPT ); Thu, 13 Jul 2023 23:17:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234804AbjGNDRD (ORCPT ); Thu, 13 Jul 2023 23:17:03 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58C7D30DC for ; Thu, 13 Jul 2023 20:16:55 -0700 (PDT) Received: from canpemm500007.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4R2GmR3gZdzLnmD; Fri, 14 Jul 2023 11:14:31 +0800 (CST) Received: from [10.174.179.215] (10.174.179.215) by canpemm500007.china.huawei.com (7.192.104.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 14 Jul 2023 11:16:53 +0800 Subject: Re: [PATCH -next] x86: ia32.h: Remove unused code To: , , , , , CC: References: <20230625125411.25840-1-yuehaibing@huawei.com> From: YueHaibing Message-ID: <83d2aeb0-9675-10db-f1ca-5ba4ecade4fd@huawei.com> Date: Fri, 14 Jul 2023 11:16:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20230625125411.25840-1-yuehaibing@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500007.china.huawei.com (7.192.104.62) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping... On 2023/6/25 20:54, YueHaibing wrote: > Since commit 32974ad4907c ("[IA64] Remove COMPAT_IA32 support") > IA32_STACK_TOP and ia32_setup_arg_pages() is not used anymore. > And commit 675a0813609f ("x86: unify mmap_{32|64}.c") left behind > ia32_pick_mmap_layout() extern declaration. > > Signed-off-by: YueHaibing > --- > arch/x86/include/asm/ia32.h | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/arch/x86/include/asm/ia32.h b/arch/x86/include/asm/ia32.h > index fada857f0a1e..68f7eefe63d3 100644 > --- a/arch/x86/include/asm/ia32.h > +++ b/arch/x86/include/asm/ia32.h > @@ -57,17 +57,6 @@ struct stat64 { > unsigned long long st_ino; > } __attribute__((packed)); > > -#define IA32_STACK_TOP IA32_PAGE_OFFSET > - > -#ifdef __KERNEL__ > -struct linux_binprm; > -extern int ia32_setup_arg_pages(struct linux_binprm *bprm, > - unsigned long stack_top, int exec_stack); > -struct mm_struct; > -extern void ia32_pick_mmap_layout(struct mm_struct *mm); > - > -#endif > - > #endif /* CONFIG_IA32_EMULATION */ > > #endif /* _ASM_X86_IA32_H */ >