From: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: alexander.usyskin@intel.com, arnd@arndb.de,
linux-kernel@vger.kernel.org, zhongqiu.han@oss.qualcomm.com
Subject: Re: [PATCH] mei: bus: Add newline to sysfs attribute outputs
Date: Thu, 30 Oct 2025 21:11:34 +0800 [thread overview]
Message-ID: <83d8d2bb-767a-4dd6-8e1b-de96164cad4c@oss.qualcomm.com> (raw)
In-Reply-To: <2025103052-taking-shredding-c77a@gregkh>
On 10/30/2025 8:32 PM, Greg KH wrote:
> On Thu, Oct 30, 2025 at 08:30:00PM +0800, Zhongqiu Han wrote:
>> Append newline characters to sysfs_emit() outputs in func max_conn_show(),
>> fixed_show(), and vtag_show(). This aligns with common kernel conventions
>> and improves readability for userspace tools that expect
>> newline-terminated values.
>
> What userspace tool reads these values today? Will this user/kernel api
> break them? How was this tested?
>
> thanks,
>
> greg k-h
Hi Greg,
Thanks for your review~
Apologies for the confusion in the commit message — there isn't
actually a userspace tool that depends on the newline in this case. I
just made the change to follow common sysfs formatting practices and
improve consistency.
If you'd prefer the patch to be dropped or revised, I will proceed
accordingly.
--
Thx and BRs,
Zhongqiu Han
next prev parent reply other threads:[~2025-10-30 13:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 12:30 Zhongqiu Han
2025-10-30 12:32 ` Greg KH
2025-10-30 13:11 ` Zhongqiu Han [this message]
2025-11-03 0:25 ` Greg KH
2025-11-03 13:43 ` Zhongqiu Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d8d2bb-767a-4dd6-8e1b-de96164cad4c@oss.qualcomm.com \
--to=zhongqiu.han@oss.qualcomm.com \
--cc=alexander.usyskin@intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®