Re: [PATCH] net: ionic: free VF resources on remove

["Creeley, Brett" <bcreeley@amd.com>]

On 9/15/2026 10:31 PM, Guangshuo Li wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> ionic_probe() allocates VF tracking data and maps a statistics buffer
> for each already enabled VF with ionic_vf_alloc().
>
> The probe failure path releases these resources with
> ionic_vf_dealloc(). However, after a successful probe, ionic_remove()
> tears down the LIF and device without releasing the VF resources.
>
> This leaves the VF tracking allocation and statistics DMA mappings
> behind when the PF driver is removed.
>
> Call ionic_vf_dealloc() before deinitializing the LIF so the VF
> statistics addresses can be cleared and the associated DMA mappings
> and tracking data released.
>
> This issue was found by manual code inspection.
>
> Fixes: fbb39807e9ae ("ionic: support sr-iov operations")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
> ---
>   drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c b/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c
> index 05f19489ec5c..666efe972de7 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c
> @@ -424,6 +424,7 @@ static void ionic_remove(struct pci_dev *pdev)
>                  ionic_auxbus_unregister(ionic->lif);
>                  ionic_lif_unregister(ionic->lif);
>                  ionic_devlink_unregister(ionic);
> +               ionic_vf_dealloc(ionic);

I meant to respond, but didn't. Anyway this LGTM, thanks for the patch.

At this point it's not worth anything, but still:

Reviewed-by: Brett Creeley <brett.creeley@amd.com>
>                  ionic_lif_deinit(ionic->lif);
>                  ionic_lif_free(ionic->lif);
>                  ionic->lif = NULL;
> --
> 2.43.0
>