From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>,
linux-security-module@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
Stephen McCamant <smccaman@umn.edu>,
James Morris <jmorris@namei.org>,
John Johansen <john.johansen@canonical.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
Tyler Hicks <tyhicks@canonical.com>
Subject: Re: [PATCH] apparmor: Fix use-after-free in aa_audit_rule_init
Date: Sun, 20 Oct 2019 16:16:19 +0200 [thread overview]
Message-ID: <83dcacc2-a820-fe63-a1b9-1809e8f14f2f@web.de> (raw)
In-Reply-To: <20191017014619.26708-1-navid.emamdoost@gmail.com>
> … But after this release the the return statement
> tries to access the label field of the rule which results in
> use-after-free. Before releaseing the rule, copy errNo and return it
> after releasing rule.
Please avoid a duplicate word and a typo in this change description.
…
> +++ b/security/apparmor/audit.c
…
> @@ -197,8 +198,9 @@ int aa_audit_rule_init(u32 field, u32 op, char *rulestr, void **vrule)
> rule->label = aa_label_parse(&root_ns->unconfined->label, rulestr,
> GFP_KERNEL, true, false);
> if (IS_ERR(rule->label)) {
> + err = rule->label;
How do you think about to define the added local variable in this if branch directly?
+ int err = rule->label;
> aa_audit_rule_free(rule);
> - return PTR_ERR(rule->label);
> + return PTR_ERR(err);
> }
>
> *vrule = rule;
Regards,
Markus
next prev parent reply other threads:[~2019-10-20 14:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 1:46 Navid Emamdoost
2019-10-20 14:16 ` Markus Elfring [this message]
2019-10-20 18:49 ` John Johansen
2019-10-21 15:23 ` [PATCH v2] " Navid Emamdoost
2019-10-21 15:45 ` Tyler Hicks
2019-10-21 16:05 ` [PATCH v3] " Navid Emamdoost
2019-10-21 16:08 ` Tyler Hicks
2019-10-21 16:06 ` [PATCH v2] " Navid Emamdoost
2019-10-24 6:20 ` kbuild test robot
2019-10-24 8:48 ` kbuild test robot
2019-10-21 15:25 ` [PATCH] " Navid Emamdoost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83dcacc2-a820-fe63-a1b9-1809e8f14f2f@web.de \
--to=markus.elfring@web.de \
--cc=emamd001@umn.edu \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=serge@hallyn.com \
--cc=smccaman@umn.edu \
--cc=tyhicks@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome