From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7597B36BCCC for ; Tue, 24 Feb 2026 09:38:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771925901; cv=none; b=jITMXaKloCSEBsPQg+Rc1TD4RoMXboRGyXPu2mwbRrrE4ok9dYSCbgWEF5WdgqzPfLQoWMY9YJsebQQGVYldphzn02UiiWWAwddgmO4CcqINZWk/Txn8WaQOKe7XmJ4DBkjZQ3mF7kyF9Gh+vc3gfHNQMIiHIJpaY09PZQjtROk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771925901; c=relaxed/simple; bh=TzBD1eRJUOUHls05wbjMwVzCLnvY9bJPv/uqA/anx7Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rK8asngZBc916C23TEaTtGbA49NozwM74YRTdK6Nk8+DEY690LTiPIgGQjeK5dohxooLiq5vAHXysBSXdLqKtFwn9D+5r/wYnJiL3IlsNv7MUQR3tIEy2D3d4zuNH0qBmoP7qkGwUjHG7B8Oph+gGBwTU1Eon1KDxjKq2hfpcnE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DltwqRYR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Bczh61pv; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DltwqRYR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Bczh61pv" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61O4LfXP2570070 for ; Tue, 24 Feb 2026 09:38:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= s1SK4xxHCghz73tk4AuBgNJLpt1PKV49tRriGiP5+AA=; b=DltwqRYRdIQcP/lF Pl5jCI1YCOekGMCbcSOdekrwtyDwnBuX4uAcwBzh3qU9UcM6V29B+zqG5PTc57y5 s4CvMG0nevsWDZx16pRJuDiHQJSA69XrhZBCHytaVChM++j8FJzyyHJmWHJ/0Qsb sYN5/H58stYjTV8rgo1adtp9/IKfH4ffi/SCGGcZEEJBJiVXX1BbdkzSrS5cvAyD Bd1n3z9VzMllWPV0nn0cYUBCd/7umvZJ9pb2ufc6iJvDeZ/O6gVBufwg5hzK8/b4 ThbanhdivJDVtMMp1uB7ToFfNahY7TBo5yCGiT2TwTVenZYlqs9VGpKTaLiVB5Fk ztjDsw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cgn8y3qab-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Feb 2026 09:38:18 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2adae3b2135so8492985ad.1 for ; Tue, 24 Feb 2026 01:38:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771925897; x=1772530697; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=s1SK4xxHCghz73tk4AuBgNJLpt1PKV49tRriGiP5+AA=; b=Bczh61pvkz49SztkjsmbCb7k4anKBL1KRMT+QN6x+P23fEWX01OKXnFf+x6Sfh8ZzS F9m/+8k0dvZIhEzhxY7l1jMElBFQPTFYZPR6cazizePfw6q6gPkYLR/kUnVKIdOcdI2y T8avamSUAm44JlwxmV2QTm8Y07RoSXNv+BCZ/D5ZlEH2Vx019lsLLyi7VUQl1bZ+mPDz eho9VA+TlVFbWeAsBXz/wJ5/+csZDhmYIzd9Is6f+URrof49Vt5UGcDOqV3L63stgnM5 wFKxop0n3XAdzivOPeJOzeDMvvVc+098gGh+c0n7r1LkaOtmUbS0oSRlfRj0gRB2bXEH wvZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771925897; x=1772530697; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s1SK4xxHCghz73tk4AuBgNJLpt1PKV49tRriGiP5+AA=; b=N3lfLPE8sQgO+RYmrAgLzHnfM0+AaRwr/8/uD2fVc1z8PYRH1ZRFr7gc/W0gGCTcw4 /5CXlzS5r6PCZmU1EyIAXlwsx+wibn7fpn/7hyHKuZGCtZ1y8xlUKSrp77K/7s5rpJPd phMiC/dzw2NLhBuXsL1jfMS1ISdZZQUazS6AlVp7ATGsJMAqpTE7YLmPh4o0CNY8Iu2v 6I1k7xrThRB77fth7qVQ9R2RGccEXBrfLUDAjyPZCTj71bhsF/CvWZRsAuGX3F54+lr8 r+Kqnddx0FbaeOXo1mxUlpXobUOXlERQvltwefUrTbtZBntI5/ERKpDb5T4dwPBWxU2i Esng== X-Forwarded-Encrypted: i=1; AJvYcCWL62hBP/LBZFPji3IK/1+2+pR6tae4Okx8TqV3JBMFEAyA6gH4/Cbfp8Saz1d9UCIjZCXnuM/aFZISiPQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwiLrNnpK4bjHF7j2BB69Gv71aYRYiNNCe0Ef9Fa9tqLZW+Gmlk v6CF1pi0ZeguxY3lpzkT2U5IOb0smLwoAjFeW1yNlGnlXZhyKe8KIz5qrFQNL1Crvn6q/IeVYJs 2pR7ichqv9Fm8P/J1OfI11etoMN4v66O1k7w+Z50Ht896Db7mqDYCKK4beaNe/2ul4QE= X-Gm-Gg: ATEYQzzZ+s1D9ETxWZffIhw3Q8T+xTSUJsOTzKZtr4oCOacmgmyTV1dn07bsbB579Nj 0x/y7h5/I1IdFexovkuHSvA+XNWyzKX37bSyg6TBr7XVAcdDRFczxeUoBl/vQbCHp3qTpoxn4jp s0GOusv7aGMM1V6E/khMOqe0MWuc2iBPgDgqM54EMSk2j1GeXgL++QApdrPOQ97LVGmiBZQPoNI RCQ+pZG8N+ci9SnS8HYsRmfxk6JkcI3o0zyaDGMx9L1M6UV6i8jpFX5tMhuwITsfG3KvJQ8R4Sj +0JmoSvuCGg1lqG+O2mW0DHo+DdZp4IhjoWtKjWUANYO7HrUG98V84oCZ2V5VvJlWulTk9MJOZo p5vuGlbURLuCgaFdPfQullE0fHwurEMTK9Vfa1MwjTnTheSvBtoEp X-Received: by 2002:a17:903:248:b0:2ad:9edf:7fe4 with SMTP id d9443c01a7336-2ad9edf81a5mr19440205ad.48.1771925897355; Tue, 24 Feb 2026 01:38:17 -0800 (PST) X-Received: by 2002:a17:903:248:b0:2ad:9edf:7fe4 with SMTP id d9443c01a7336-2ad9edf81a5mr19439945ad.48.1771925896872; Tue, 24 Feb 2026 01:38:16 -0800 (PST) Received: from [192.168.0.111] ([49.207.195.178]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad7500e19fsm104235835ad.59.2026.02.24.01.38.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Feb 2026 01:38:16 -0800 (PST) Message-ID: <83decab4-a59d-434a-8ddf-2808d7081858@oss.qualcomm.com> Date: Tue, 24 Feb 2026 15:08:09 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 5/5] arm64: dts: qcom: glymur-crd: Enable ADSP and CDSP To: Dmitry Baryshkov Cc: Konrad Dybcio , robh@kernel.org, srini@kernel.org, amahesh@qti.qualcomm.com, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, mathieu.poirier@linaro.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org References: <20260129001358.770053-1-sibi.sankar@oss.qualcomm.com> <20260129001358.770053-6-sibi.sankar@oss.qualcomm.com> <24973bc9-a082-42ec-89f4-12758ddca136@oss.qualcomm.com> <8d96ebc8-67e2-424d-adbc-0948dd3641a0@oss.qualcomm.com> <48778fa8-b485-4c79-be1a-c70836f65f0b@oss.qualcomm.com> Content-Language: en-US From: Sibi Sankar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI0MDA4MSBTYWx0ZWRfX9YKGE6G/jSjI QhzwKMRPf2918oxByt9GaJuQbSc8g14ELSjkWznPfAb3V5ipxUk8u5kZ3MTgEobKct9gZ3f/+HO rZPwzhl9dwqXQwy6MpD+E7xnJEmVZQrrS5f+k7sQRWoxpr1bWFCrilbcwX/zFcwvHuXJ1TUyEBd l3DHShOZzGiDosvNhQFLeMMDQhQlwt/6bahN3R0rwTfPCvQT8wBLMfLQ8rucxjJ2m6sgkZRo7yC hRPaZlEJEnYtci9aCLvJx6Tb1XIU66pEHPOHqw/KllrIBUccA5FRba5eSnaPMIcsIEul6EbIrTg cBSJQg+3XFrnUggdXxsFWtWsp1hsR7CcNiqthxBbSO4w7V16AytLAi/LOeIZqJVGLftuXToZOY3 k9K/ri1798cu62Hfm0xLJK/VWUfU2HRzLzFeZiceEj4QYv36IYLdzkxEal3cllOS+0SXJYb17J9 kvyuNe3DXSj7najyj3A== X-Authority-Analysis: v=2.4 cv=edYwvrEH c=1 sm=1 tr=0 ts=699d718a cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=FDuvZuZHjihTmU/CkdNO9w==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=pNNgpXSRwlUzhS52UYoA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: jCJ7F7irqy-v5y4hK8Tj7BeYjDmLju02 X-Proofpoint-ORIG-GUID: jCJ7F7irqy-v5y4hK8Tj7BeYjDmLju02 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-24_01,2026-02-23_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 phishscore=0 clxscore=1015 priorityscore=1501 spamscore=0 impostorscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602240081 On 2/24/2026 12:00 PM, Dmitry Baryshkov wrote: > On Tue, Feb 24, 2026 at 11:48:00AM +0530, Sibi Sankar wrote: >> On 2/23/2026 10:44 PM, Dmitry Baryshkov wrote: >>> On Mon, 23 Feb 2026 at 11:09, Sibi Sankar wrote: >>>> On 2/3/2026 6:09 PM, Dmitry Baryshkov wrote: >>>>> On Mon, Feb 02, 2026 at 11:16:19AM +0100, Konrad Dybcio wrote: >>>>>> On 1/31/26 8:54 AM, Dmitry Baryshkov wrote: >>>>>>> On Fri, Jan 30, 2026 at 10:55:24AM +0100, Konrad Dybcio wrote: >>>>>>>> On 1/29/26 1:13 AM, Sibi Sankar wrote: >>>>>>>>> Enable ADSP and CDSP on Glymur CRD board. >>>>>>>>> >>>>>>>>> Signed-off-by: Sibi Sankar >>>>>>>>> --- >>>>>>>>> arch/arm64/boot/dts/qcom/glymur-crd.dts | 14 ++++++++++++++ >>>>>>>>> 1 file changed, 14 insertions(+) >>>>>>>>> >>>>>>>>> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dts b/arch/arm64/boot/dts/qcom/glymur-crd.dts >>>>>>>>> index 0899214465ac..0eed4faa8b07 100644 >>>>>>>>> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dts >>>>>>>>> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dts >>>>>>>>> @@ -487,6 +487,20 @@ &pon_resin { >>>>>>>>> status = "okay"; >>>>>>>>> }; >>>>>>>>> >>>>>>>>> +&remoteproc_adsp { >>>>>>>>> + firmware-name = "qcom/glymur/adsp.mbn", >>>>>>>>> + "qcom/glymur/adsp_dtb.mbn"; >>>>>>>>> + >>>>>>>>> + status = "okay"; >>>>>>>>> +}; >>>>>>>>> + >>>>>>>>> +&remoteproc_cdsp { >>>>>>>>> + firmware-name = "qcom/glymur/cdsp.mbn", >>>>>>>>> + "qcom/glymur/cdsp_dtb.mbn"; >>>>>>>>> + >>>>>>>>> + status = "okay"; >>>>>>>>> +}; >>>>>>>> Please make sure it gets to L-F (only Kaanapali is there right now) >>>>>>>> >>>>>>>> Reviewed-by: Konrad Dybcio >>>>>>> Hmm, looking at x1e80100-crd which references qcom/x1e80100/adsp.mbn, >>>>>>> but the firmware in linux-firmware is (now) targeting IoT devices, >>>>>>> should we use WoA-like names for firmware on Glymur CRD instead >>>>>>> (qcadsp-something.mbn). It would match what was done for the SC8280XP >>>>>>> CRD. >>>>>> I think it's simply time to stop pretending the firmware is generic >>>>>> (some fw simply isn't and some fw may come from different/incompatible >>>>>> branchpoints) and include a board name in the path >>>>> Well... CDSP is usually generic, except for WP vs non-WP. >>>> Hey Dmitry/Konrad, >>>> >>>> Thanks for taking time to review the series :) >>>> >>>> The ADSP/CDSP firmware that got upstreamed to linux-firmware got their >>>> functionality tested on Glymur WP CRD devices. Given that the firmware >>>> has already landed, can I continue to use the same name as the patch and >>>> have a different name for other boards if something specific has to be >>>> pushed >>>> for IOT? >>> Thank you for a prompt reaction, it took just 20 days. During that >>> time we could have fixed WP firmware filenames, but... linux-firmware >> Hey Dmitry, >> >> I'm really sorry that this happened this way :( but I was out >> on vacation the past three weeks getting married. A quick >> review comment on the firmware pull request for naming >> change request would also sufficed in the interim. Also to address >> some of your concerns there aren't any plans to push an iot >> specific ADSP/CDSP firmware for Glymur reference devices. > There are no plans to push or there are no plans to have it? I've been told that the plan is to use the same firmware for IOT SKUs as well. Also in case they do update the firmware in the future, it would be tested for any regression against WP targets. >> Also, this series already warrants a re-post so I can still >> accommodate your naming requests with corresponding >> updates to linux-firmware. > Yes, but the linux-firmware has been released with these file names, so > you can't just change them. You will have to provide > backwards-compatibility links, which defeats the purpose. > >> -Sibi >> >>> got released just two days ago, so we can't fix that anymore. Now we >>> don't have any other option than to use a non-standard name for IoT >>> firmware when it comes later. >>> >>>> -Sibi >>>>