From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936512AbcIRPSl (ORCPT ); Sun, 18 Sep 2016 11:18:41 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:50620 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932796AbcIRPSb (ORCPT ); Sun, 18 Sep 2016 11:18:31 -0400 Subject: Re: [PATCH 08/10] ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5410/exynos542x To: Krzysztof Kozlowski , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1474054971-16831-1-git-send-email-krzk@kernel.org> <1474054971-16831-9-git-send-email-krzk@kernel.org> Cc: Marek Szyprowski , Bartlomiej Zolnierkiewicz , Geert Uytterhoeven , Alban Browaeys , Marc Zyngier From: Javier Martinez Canillas Message-ID: <83ea3f1f-476a-0a49-abe5-1bafaa269dd2@osg.samsung.com> Date: Sun, 18 Sep 2016 11:18:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1474054971-16831-9-git-send-email-krzk@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 09/16/2016 03:42 PM, Krzysztof Kozlowski wrote: > Interrupt of type IRQ_TYPE_NONE is not allowed for GIC interrupts and > generates an error: > genirq: Setting trigger mode 0 for irq 16 failed (gic_set_type+0x0/0x68) > > The GIC requires shared interrupts to be edge rising or level high. > Platform declares support for both. Choose level high everywhere. > > Reported-by: Marek Szyprowski > Reported-by: Geert Uytterhoeven > Reported-by: Alban Browaeys > Cc: Marc Zyngier > Signed-off-by: Krzysztof Kozlowski > --- Tested-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America