From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB173EC875E for ; Thu, 7 Sep 2023 20:31:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234373AbjIGUbf (ORCPT ); Thu, 7 Sep 2023 16:31:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231590AbjIGUba (ORCPT ); Thu, 7 Sep 2023 16:31:30 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD6551BCE for ; Thu, 7 Sep 2023 13:31:21 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-9a6190af24aso168346966b.0 for ; Thu, 07 Sep 2023 13:31:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694118680; x=1694723480; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=ZefjAhchqyrxVQ2DJ6c4dlOP9vaj1j8yweD0z7WDVhY=; b=HWIvvLTfz4XB14rjtaLjnRf9l8NVNaZiHmcARkIGJ/8OStEkpudHHw+olZ533GvotQ h9QPugdt0B31iGxwtWWlCceYJZBc0CzC+1FpD1o33SqScvJmwv2tRXGl5Da/1lVkuuJE giB066wNyAD+Xaps4z6c0/mzTStkM/lwmpmaCbnAdHMtMdztVLudw8Szgy7Mk8tA3Ps5 wmoCfZOvu2qvPlLkq3gdZ5FpzxP8q1sj5JFd0+Ynrs/GkSY9J0ysBPWUF5EPo9mm7E0w oP9nPzSh0C2hXsmUJccGb+QedYgml551p9yG/af9fKHN0hXxeT0Emgsi+rbkpV+a6pbm yFpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694118680; x=1694723480; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZefjAhchqyrxVQ2DJ6c4dlOP9vaj1j8yweD0z7WDVhY=; b=bI88CYcw+nrJMFD7PrP3otFiXP5CH9itM/Z+kJTGC+Cb9hMgVTu6e11E1RVMaGDJtc OykOeh1TBHMFrSpuGJ23ttID1Tgv5gm8UsZ5nOfDxVlXaoL4ywyDXpcDAKyOsQI5x5J1 tax72dynO8VlWOW2oDosr+7XjTtf01Ak271pv0NlNdvTjtS4J3XSqELzIdlqngn6LqMz aYEonStIz0lhEsHMYig6jI9t9rigZtWs9NWf4XkCpjitOVJ6kjmKud2kOstuLa6hjCr2 G8cbtCkynxdGpitgCqYzmbKakq8bmhl6QpiXCWj+a2Gh4kHZ6IV44UyAJq4Rn33nqJDd vA2g== X-Gm-Message-State: AOJu0YzRQuP2HQxuNFD2aMdM1attwMw721may3hwYhN/nQKvtHMsssKb eL2UNfnW6+2oc++GpGZ/k4xfyA== X-Google-Smtp-Source: AGHT+IH7JJlh/7Du+y2RvkjKLmIqau/6pAfe62XTrJ0/LsPjJUHWz7ru3A3zZycvW48SmvrZIJB/9A== X-Received: by 2002:a17:906:2d0:b0:9a1:bd53:b23 with SMTP id 16-20020a17090602d000b009a1bd530b23mr287303ejk.14.1694118680135; Thu, 07 Sep 2023 13:31:20 -0700 (PDT) Received: from [192.168.37.234] (178235177164.dynamic-4-waw-k-1-1-0.vectranet.pl. [178.235.177.164]) by smtp.gmail.com with ESMTPSA id ck19-20020a170906c45300b009a1a653770bsm87318ejb.87.2023.09.07.13.31.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Sep 2023 13:31:19 -0700 (PDT) Message-ID: <83f88e88-5624-4ffd-b2df-f58c6988c649@linaro.org> Date: Thu, 7 Sep 2023 22:31:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/7] leds: rgb: leds-qcom-lpg: Update PMI632 lpg_data to support PPG Content-Language: en-US From: Konrad Dybcio To: Anjelique Melendez , pavel@ucw.cz, lee@kernel.org, thierry.reding@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, agross@kernel.org, andersson@kernel.org Cc: luca.weiss@fairphone.com, u.kleine-koenig@pengutronix.de, quic_subbaram@quicinc.com, quic_gurus@quicinc.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org, kernel@quicinc.com References: <20230830180600.1865-2-quic_amelende@quicinc.com> <20230830180600.1865-8-quic_amelende@quicinc.com> <951a2f24-931a-4a25-a3b7-c3009e135d7d@linaro.org> Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7.09.2023 22:26, Konrad Dybcio wrote: > On 7.09.2023 21:54, Anjelique Melendez wrote: >> >> >> On 8/30/2023 11:34 AM, Konrad Dybcio wrote: >>> On 30.08.2023 20:06, Anjelique Melendez wrote: >>>> Update the pmi632 lpg_data struct so that pmi632 devices use PPG >>>> for LUT pattern. >>>> >>>> Signed-off-by: Anjelique Melendez >>>> --- >>>> drivers/leds/rgb/leds-qcom-lpg.c | 9 ++++++--- >>>> 1 file changed, 6 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c >>>> index 90dc27d5eb7c..0b37d3b539f8 100644 >>>> --- a/drivers/leds/rgb/leds-qcom-lpg.c >>>> +++ b/drivers/leds/rgb/leds-qcom-lpg.c >>>> @@ -1672,11 +1672,14 @@ static const struct lpg_data pm8994_lpg_data = { >>>> static const struct lpg_data pmi632_lpg_data = { >>>> .triled_base = 0xd000, >>>> >>>> + .lut_size = 64, >>>> + .lut_sdam_base = 0x80, >>> Is that a predefined space for use with LPG? >>> >>> Or can it be reclaimed for something else? >>> >>> Konrad >> Yes, this is a predefined space for use with LPG > We represent the SDAM as a NVMEM device, generally it would > be nice to add all regions within it as subnodes in the devicetree. Wait hmm.. we already get it as a nvmem cell.. Or at least that's how I understand it (lut_sdam_base == lpg_chan_nvmem->start, pseudocode) Why don't we access it through the nvmem r/w ops then? Konrad > > Krzysztof, opinions? > > Konrad