mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Cambda Zhu <cambda@linux.alibaba.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: skip macros when finding missing switch/case break
Date: Fri, 31 Jul 2020 11:05:27 -0700	[thread overview]
Message-ID: <83fc36d8c87408298a4cd6d66b140b330f2c45b0.camel@perches.com> (raw)
In-Reply-To: <20200729125911.47318-1-cambda@linux.alibaba.com>

On Wed, 2020-07-29 at 20:59 +0800, Cambda Zhu wrote:
> The checkpatch.pl only searches 3 previous lines when finding missing
> switch/case break, and macros are treated as normal statements. If the
> cases are surrounded with CONFIG, checkpatch.pl may report false
> warnings. For example:

Likely this test should be removed altogether as
it's never really worked well and now compilers
find this and emit warnings.



  reply	other threads:[~2020-07-31 18:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29 12:59 Cambda Zhu
2020-07-31 18:05 ` Joe Perches [this message]
2020-08-01  5:03 Cambda Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83fc36d8c87408298a4cd6d66b140b330f2c45b0.camel@perches.com \
    --to=joe@perches.com \
    --cc=cambda@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®