From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D1D6C433EF for ; Mon, 25 Jul 2022 10:37:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234634AbiGYKhz (ORCPT ); Mon, 25 Jul 2022 06:37:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232413AbiGYKhw (ORCPT ); Mon, 25 Jul 2022 06:37:52 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3315A18344 for ; Mon, 25 Jul 2022 03:37:51 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id i205-20020a1c3bd6000000b003a2fa488efdso3323499wma.4 for ; Mon, 25 Jul 2022 03:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=+9DH2yvpmzJTbR5IRlHExx56HEvkEyqIpYZIUzY5w+A=; b=FJps3xWD3fTcLB5G6iYtWvZ04LSQQ460w2JesdVKAYJcYQ0VZ2CeLNBqG8wT1SwGTZ KxkkceVqsAXI0cmlTQ8/iOH/Ad6WR+ID84f0jCBhf6PN+z5SplCiEg/3GUKUFaMiuMkW EviuOr15IgnDYAMFTARD+yJXWwCBjtGCt+5EMeClBR1ooU0CiwdwcioQbTzXwJ/inTZS ULH3P3Rdq1vUgXkhicNx6sDLb12vG/rq2ROAirRjQBh6bW+fpV9TKJtGuuexSuF7YdDp /vaRsg99tahX6PHl3UaF6xcyxO40ipCFmysAftFWor/QqI2Tnv/oZT4TXYOyTgnrXKyl W+hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=+9DH2yvpmzJTbR5IRlHExx56HEvkEyqIpYZIUzY5w+A=; b=N2e6V5LgCKz8eFzzZq29AXERE7VRwD783Vg9YThKEknKB4Iw2i+iwtuDChZ2ZDPHBz z+o0xFRrTZml9HQvJpkDmzICvMPUjNKc46jURgL2IYn8RdgVG9ZM6oSbOL4C3IXJWs+T FGIoy6ZucT0gxI1uviAXDNSU8c2bbCgC7as5b9GaXuQUl4do/6WojWTzCIwNP2jzjWpz E8UoDJUSctYwt/6av5g3rMvbowvwkpNWhY+8o6+I4aXZ3t5pPmqNWLBjSEwmuXgj19KE pRBoEI3EZFR+z686IO5g1MdPdyQE27UVXiBn4ZFArLCVv2xGGtSmeBzAZ3pZhORnuqoK LEUQ== X-Gm-Message-State: AJIora8DLP9s0rmzZq/OVIR6NyCXY0N2ZkyT3Xi9S8sl7alBhinyo0Jh X96rehvTUZ/xQDl2XTbqFpkkyg== X-Google-Smtp-Source: AGRyM1ui0IeqFV27TNP9tXSKwFKHp50Fq3KFu4y2q1dEhoKO6vTUYsV1xBAWfptX9qaAPUV9SUc6OQ== X-Received: by 2002:a1c:f313:0:b0:3a3:1117:282d with SMTP id q19-20020a1cf313000000b003a31117282dmr21119036wmq.40.1658745469737; Mon, 25 Jul 2022 03:37:49 -0700 (PDT) Received: from [192.168.1.6] ([195.24.90.54]) by smtp.googlemail.com with ESMTPSA id y2-20020a5d6142000000b0021d70a871cbsm11606346wrt.32.2022.07.25.03.37.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Jul 2022 03:37:49 -0700 (PDT) Message-ID: <83fcf3ef-9b85-2307-c5f2-c4609af059f7@linaro.org> Date: Mon, 25 Jul 2022 13:37:47 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/7] venus : Addition of control support - V4L2_CID_MIN_BUFFERS_FOR_OUTPUT Content-Language: en-US To: Viswanath Boma , video.upstream.external@qti.qualcomm.com, Stanimir Varbanov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220712122347.6781-1-quic_vboma@quicinc.com> <20220712122347.6781-2-quic_vboma@quicinc.com> From: Stanimir Varbanov In-Reply-To: <20220712122347.6781-2-quic_vboma@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/12/22 15:23, Viswanath Boma wrote: > V4l2 encoder compliance expecting minimum buffers support for the application to allocate > buffers as per the control support values. Please start the sentence from the beginning. > > Change-Id: Idb41ff7dce8b8138f28df01d045eae6facf7e93d No Change-Ids, please. > Signed-off-by: Viswanath Boma > --- > drivers/media/platform/qcom/venus/venc_ctrls.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/venus/venc_ctrls.c b/drivers/media/platform/qcom/venus/venc_ctrls.c > index 37ba7d97f99b2..95fdad160732b 100644 > --- a/drivers/media/platform/qcom/venus/venc_ctrls.c > +++ b/drivers/media/platform/qcom/venus/venc_ctrls.c > @@ -355,7 +355,7 @@ int venc_ctrl_init(struct venus_inst *inst) > struct v4l2_ctrl_hdr10_mastering_display p_hdr10_mastering = { {34000, 13250, 7500 }, > { 16000, 34500, 3000 }, 15635, 16450, 10000000, 500 }; > > - ret = v4l2_ctrl_handler_init(&inst->ctrl_handler, 58); > + ret = v4l2_ctrl_handler_init(&inst->ctrl_handler, 59); > if (ret) > return ret; > > @@ -435,6 +435,9 @@ int venc_ctrl_init(struct venus_inst *inst) > V4L2_MPEG_VIDEO_VP8_PROFILE_3, > 0, V4L2_MPEG_VIDEO_VP8_PROFILE_0); > > + v4l2_ctrl_new_std(&inst->ctrl_handler, &venc_ctrl_ops, You did not provide a g_ctrl handler for this ? > + V4L2_CID_MIN_BUFFERS_FOR_OUTPUT, 4, 11, 1, 4); > + > v4l2_ctrl_new_std(&inst->ctrl_handler, &venc_ctrl_ops, > V4L2_CID_MPEG_VIDEO_BITRATE, BITRATE_MIN, BITRATE_MAX, > BITRATE_STEP, BITRATE_DEFAULT); -- regards, Stan