From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84ACBC04AAC for ; Mon, 20 May 2019 11:16:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63DD720815 for ; Mon, 20 May 2019 11:16:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732584AbfETLQ2 (ORCPT ); Mon, 20 May 2019 07:16:28 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:36527 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732569AbfETLQ1 (ORCPT ); Mon, 20 May 2019 07:16:27 -0400 Received: by mail-wr1-f66.google.com with SMTP id s17so14154640wru.3 for ; Mon, 20 May 2019 04:16:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZxAda8y+Lw5w6X737KJdEPUh+wkc1U8IjaEMWE3lVAU=; b=eTNCxaS2fiukbRm1IuMBGwKEV6E5hABTE6gCZZURcfa4v7re/76LAu3LjmuF8IrD6s ME/3WG0vK4QOx1l8u/3dBylKA0bf+18FOQce+GUL77daNX3i8Jmwip77Y/KsYyPuAFlT r7xj9hJ8YnIfVmh2a9TgOkEtnOiYb48y/UwTQBeY54Ub1d5nTCA335sOl4bN72EyiReD S22VAZvkobZZfStMFXnl5eaePCoCRH7mUB32gu4rHAdsX/Zx+f4RcIB2AXFb1Y8shB1c cT666VT25HmKOBbgY+rM56GX/Iljfsg25yvUqgK42XQLZpJZzXwuGexv4Zi5mlIF32oJ ZDNA== X-Gm-Message-State: APjAAAVrq5QM7ADh0S6tf+2WWHFz0AIAJpXbBKIAoU1w61fpmE3qeYyP 5lBQe9i57i/yrD8MD7kRNebNtwM5pKWKFQ== X-Google-Smtp-Source: APXvYqxKv0sQ2iquFAoDIXnp3sduGK6TezmZvrJwiMji2N1+QfUnBhmOkknC6pCZTEflbhnzO3ZTiQ== X-Received: by 2002:adf:dc04:: with SMTP id t4mr41535607wri.126.1558350985398; Mon, 20 May 2019 04:16:25 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:ac04:eef9:b257:b844? ([2001:b07:6468:f312:ac04:eef9:b257:b844]) by smtp.gmail.com with ESMTPSA id 91sm25337283wrs.43.2019.05.20.04.16.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 May 2019 04:16:24 -0700 (PDT) Subject: Re: [PATCH] KVM: selftests: Remove duplicated TEST_ASSERT in hyperv_cpuid.c To: Thomas Huth , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Vitaly Kuznetsov Cc: Shuah Khan , linux-kselftest@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190520105511.12471-1-thuth@redhat.com> From: Paolo Bonzini Message-ID: <8402b29a-6be4-b123-eb14-80b3fa8d8080@redhat.com> Date: Mon, 20 May 2019 13:16:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190520105511.12471-1-thuth@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/05/19 12:55, Thomas Huth wrote: > The check for entry->index == 0 is done twice. One time should > be sufficient. > > Suggested-by: Vitaly Kuznetsov > Signed-off-by: Thomas Huth > --- > Vitaly already noticed this in his review to the "Fix a condition > in test_hv_cpuid()" patch a couple of days ago, but so far I haven't > seen any patch yet on the list that fixes this ... if I missed it > instead, please simply ignore this patch. > > tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c > index 9a21e912097c..8bdf1e7da6cc 100644 > --- a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c > +++ b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c > @@ -52,9 +52,6 @@ static void test_hv_cpuid(struct kvm_cpuid2 *hv_cpuid_entries, > TEST_ASSERT(entry->index == 0, > ".index field should be zero"); > > - TEST_ASSERT(entry->index == 0, > - ".index field should be zero"); > - > TEST_ASSERT(entry->flags == 0, > ".flags field should be zero"); > > Queued, thanks. Paolo