From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A922C4332F for ; Tue, 22 Nov 2022 21:15:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234768AbiKVVPQ (ORCPT ); Tue, 22 Nov 2022 16:15:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234697AbiKVVPM (ORCPT ); Tue, 22 Nov 2022 16:15:12 -0500 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A19B7ECAC for ; Tue, 22 Nov 2022 13:15:09 -0800 (PST) Received: by mail-ej1-x631.google.com with SMTP id me22so22028023ejb.8 for ; Tue, 22 Nov 2022 13:15:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=61JqF5d+7+dTLDUDG/R6nmdQVS+wlcZWOGVBUq1+qvM=; b=hps2iygfkd1nHt3muzPJwDRZvqZC3BoUZ3q9wU1uFCB7NeG/yiHXK/jiKDAMKHBwMs hXd8/SjlLOYS/y2/pjEAsUOVeokcC0NztFRsnmdYxK6mCvlQ2qejG01QNrLxAeCW2MSF v5vG28IJ66uA3ea7roBwawMJ9EqJLvfTtzhqQoHiTrK56lobKGtU+cm30Fkq5/HSpBdR BNHExdUhaohiq9UKufykn5Xe0JNe4ZwQDWdlRcEoTNWjZD0heC/hcQ9tdi9Sfd+3U0ve EzG9iQUukHJqWOmtq1iGly8nY/xwbWkSKeMD9d9zRIJJJacgGQbHudN16hOjws8vXS4m DPxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=61JqF5d+7+dTLDUDG/R6nmdQVS+wlcZWOGVBUq1+qvM=; b=PytrGZ9+BFamkXXtEuPsAyliTWnbIpo4gzIu+iRYUACYF122wI58G1Ffn9uBYhH+jp ZIAZRi3tYUezb51KW5e4U7HluIkdNSdReGlR9FqFEiWMmOXThh2rGTu7F6aebGkut4IC dSlPdYn7ybcdU5Ivuy2wret+h/j1CDZbyT13HHQRl8h1cwu6el9J3JmZBLPDRdbdeViF pf16s/PKvdSgUBXdec7qcid2kRe4WFuGm0L0JeH2m7Wc1J2jEI8Ufb9D8DFXAzuv9cXe zRXIcp2sWre/C9dhCEltBQgvtXIwFzpVQB5CJJ2d/tuE9w2D0NJo5GlSnY9COO0SLFDL KTcQ== X-Gm-Message-State: ANoB5pmQVLJ/+4pt6l8KUtYviEp0PCIcxycrCwSIWSVPtc7xOhfwYa7j LbdC6IUuC3+B4Iw95oLNFMHsRw== X-Google-Smtp-Source: AA0mqf7v57zSC46AnC4u69lZL0+fqfUDKTuWXGXf7YBfKZk4SuG93TuTxHsO4Tb6/zbHZJVkfczxzg== X-Received: by 2002:a17:906:b80d:b0:78d:314e:b0fa with SMTP id dv13-20020a170906b80d00b0078d314eb0famr10404821ejb.370.1669151707886; Tue, 22 Nov 2022 13:15:07 -0800 (PST) Received: from [192.168.0.161] (79-100-144-200.ip.btc-net.bg. [79.100.144.200]) by smtp.gmail.com with ESMTPSA id kv9-20020a17090778c900b0078b03d57fa7sm6406432ejc.34.2022.11.22.13.15.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Nov 2022 13:15:07 -0800 (PST) Message-ID: <840d6f2a-abc9-c5d3-d1d3-3862e479509a@blackwall.org> Date: Tue, 22 Nov 2022 23:15:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH net-next 2/2] bonding: fix link recovery in mode 2 when updelay is nonzero Content-Language: en-US From: Nikolay Aleksandrov To: Jonathan Toppins , Paolo Abeni , netdev@vger.kernel.org, Jay Vosburgh Cc: Veaceslav Falico , Andy Gospodarek , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-kernel@vger.kernel.org References: <38fbc36783d583f805f30fb3a55a8a87f67b59ac.camel@redhat.com> <1fe036eb-5207-eccd-0cb3-aa22f5d130ce@redhat.com> <5718ba71a8755040f61ed7b2f688b1067ca56594.camel@redhat.com> <0e7bb31c-ca92-dac2-4d29-5eb2d3327b26@blackwall.org> In-Reply-To: <0e7bb31c-ca92-dac2-4d29-5eb2d3327b26@blackwall.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/11/2022 23:12, Nikolay Aleksandrov wrote: > On 22/11/2022 17:37, Jonathan Toppins wrote: >> On 11/22/22 09:45, Paolo Abeni wrote: >>> On Tue, 2022-11-22 at 08:36 -0500, Jonathan Toppins wrote: >>>> On 11/22/22 05:59, Paolo Abeni wrote: >>>>> Hello, >>>>> >>>>> On Fri, 2022-11-18 at 15:30 -0500, Jonathan Toppins wrote: >>>>>> Before this change when a bond in mode 2 lost link, all of its slaves >>>>>> lost link, the bonding device would never recover even after the >>>>>> expiration of updelay. This change removes the updelay when the bond >>>>>> currently has no usable links. Conforming to bonding.txt section 13.1 >>>>>> paragraph 4. >>>>>> >>>>>> Signed-off-by: Jonathan Toppins >>>>> >>>>> Why are you targeting net-next? This looks like something suitable to >>>>> the -net tree to me. If, so could you please include a Fixes tag? >>>>> >>>>> Note that we can add new self-tests even via the -net tree. >>>>> >>>> >>>> I could not find a reasonable fixes tag for this, hence why I targeted >>>> the net-next tree. >>> >>> When in doubt I think it's preferrable to point out a commit surely >>> affected by the issue - even if that is possibly not the one >>> introducing the issue - than no Fixes as all. The lack of tag will make >>> more difficult the work for stable teams. >>> >>> In this specific case I think that: >>> >>> Fixes: 41f891004063 ("bonding: ignore updelay param when there is no active slave") >>> >>> should be ok, WDYT? if you agree would you mind repost for -net? >>> >>> Thanks, >>> >>> Paolo >>> >> >> Yes that looks like a good one. I will repost to -net a v2 that includes changes to reduce the number of icmp echos sent before failing the test. >> >> Thanks, >> -Jon >> > > One minor nit - could you please change "mode 2" to "mode balance-xor" ? > It saves reviewers some grepping around the code to see what is mode 2. > Obviously one has to dig in the code to see how it's affected, but still > it is a bit more understandable. It'd be nice to add more as to why the link is not recovered, > I get it after reading the code, but it would be nice to include a more detailed explanation in the > commit message as well. > > Thanks, > Nik > Ah, I just noticed I'm late to the party. :) Nevermind my comments, no need for a v3.