From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 499F4137C2A for ; Mon, 24 Jun 2024 12:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719232140; cv=none; b=NaLKTfIv62zkpjRb0ys1rX6XNEWLM7qpXIrynGecPR0VqDwBrxRzlO/abDJqvLoZJ6Yl1xylJSHUBUYpHMiM3Kn3rmsDWLzSqDab4GDlatjkfbgMKVEi2mK8i555jsHTljFMOcI9zUSbiVRpjVqZnzsMQnVJEIQEy+48sykyfbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719232140; c=relaxed/simple; bh=dcN/II1fB3fyBONDBLLZCk8gdNXtHdSeIRew0TrKi3k=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=YnjdM2NTPEOsJjwQjuD2k6ERUEmLaUo2OYmMf8aqa6/TI6l9l7ku4qRWm7x5vzfSOLd/YpN4faRZUZA/RwcoAcpR7cDfUGe/eUX2xsCG0EmlSnRdzcJ6S0Qr30B4CcGoiZ6LY4qOAKN/4yWul9AMZuvcDkhZ1R+JRIjHZL4Uee8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=b2yeBJGT; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="b2yeBJGT" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-42172ab4b60so35461065e9.0 for ; Mon, 24 Jun 2024 05:28:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719232136; x=1719836936; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=WlA9v9E5rLW5BJwlAwnue18OC9Ckv8XqZKHkE4uzM1k=; b=b2yeBJGTAu39mVOwmwqbg0Cha+H/MpnZ0ZzvUWX6VloEoDx1mdRvMQfOiwQZxMbfBo hDHd7s3av82V4qh7yLouUYIG0C4H1NR9c+IwoQsDcWmhuZv1PW+dwsiSXCm2Nx0pLXOs MwW2E/VK6pS7xy0OSa4lpYP3fNWfXKYCBM4RhoCn0Yc9y05SQ2lD8Hy9t+k+h+mmm3Jy 1SKAqObU6gpgNcM5x4D1du0iAaYn4Gsfxm2e+y/IyVGgk7N4uNXylLPb9Co92+QMm3gN hH2x5ga6ox8/r7MFgxRcrvEGs7G9JymKvbtI7Bz0+CXLjTN4xpIA6rqgvEWGTalx5jDK R2SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719232136; x=1719836936; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=WlA9v9E5rLW5BJwlAwnue18OC9Ckv8XqZKHkE4uzM1k=; b=WkgIRmXmUk+jtWg/arKLEl++U9lk6x1Vt03xzeJAs/M1ptYAlvNkWDnuC4mF+xOUaz ZFX6bagAk4961AOqxqwSr/uIjRhaXOr+xNdLicJ+vTiP+46j/X3CTEiniE/wsm7di3um 2ixwWUH9RizHasZ5q9Mjl1qIO5vf4n0EuDhptTfyjS9SZA1Tr0Nk2MhIb6RKARbDqrWT oIyYc4Jix5l1pteBrNkzMcGBkw+dRPMjf2ODLHmqG5/Cr5mYvK/utSjrjQVeowQCm59A gftycr1z1y5Lddp+w6WrOJkn8R5BgCGf+WjEZt7bH7LCzQVTPuof3MMpc+WNBzVJsDc4 fsSA== X-Forwarded-Encrypted: i=1; AJvYcCU5anuZZA1Wq2St0L1vKS0hSsWrr7/fwL7cXtVvzCJUed0d1FT1FvR38tk72AnfqY/+lMznY3rkwpUcTCMq5r+BnAEIrTEyKvb+sgqz X-Gm-Message-State: AOJu0YxlHbshNbgdTJDtGD9C6+fUsmyZLnU7p6PL2NqifksYCc9uxmJ+ cHYNEiGtS4Dt3513bkQ5Pgz9m8Q2XZj1Kg0B93dU2BiIEz/kMPUbyx0QTn+lxBc= X-Google-Smtp-Source: AGHT+IFQq9CtT8zvEAVl3kDetfKcCoUO3QW3012KAC6heV8LSZ52bUALK/vq7HT2wbCGe8+eSAMpNA== X-Received: by 2002:a05:600c:5116:b0:424:9728:25d6 with SMTP id 5b1f17b1804b1-424972827bemr7690355e9.0.1719232136009; Mon, 24 Jun 2024 05:28:56 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:cf01:774b:55fd:ab74? ([2a01:e0a:982:cbb0:cf01:774b:55fd:ab74]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-366387cf523sm9950693f8f.25.2024.06.24.05.28.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jun 2024 05:28:55 -0700 (PDT) Message-ID: <8411fee8-7e09-421a-a52b-487acd3a3e24@linaro.org> Date: Mon, 24 Jun 2024 14:28:54 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 3/3] arm64: dts: qcom: prefer host mode on dev boards To: Caleb Connolly , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240624-b4-rb2-fixes-v1-0-8d763ee4e42e@linaro.org> <20240624-b4-rb2-fixes-v1-3-8d763ee4e42e@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20240624-b4-rb2-fixes-v1-3-8d763ee4e42e@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 24/06/2024 14:23, Caleb Connolly wrote: > Generally, when given the choice these boards should prefer host mode > since they're SBCs. When attached to a laptop (which is host-only) they > should still fall back to peripheral mode. It's really not what I observed on sm8550/sm8650 QRD/HDK, as the power is setup for peripheral by the bootloader and without an actual UCSI/PD negociation it would only be functionnal as peripheral mode. So this is definitely untrue on sm8450/sm8550/sm8650 HDK/QRD/MTP. Neil > > Suggested-by: Dmitry Baryshkov > Signed-off-by: Caleb Connolly > --- > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 1 + > arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 4 ++++ > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 4 ++++ > arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 1 + > arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 4 ++++ > arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 1 + > arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 4 ++++ > arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 4 ++++ > arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 4 ++++ > arch/arm64/boot/dts/qcom/sm8650-hdk.dts | 4 ++++ > arch/arm64/boot/dts/qcom/sm8650-mtp.dts | 4 ++++ > arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 4 ++++ > 12 files changed, 39 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > index c4cde4328e3d..bac4ed5874b6 100644 > --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > @@ -657,8 +657,9 @@ &usb_1 { > > &usb_1_dwc3 { > dr_mode = "otg"; > usb-role-switch; > + role-switch-default-mode = "host"; > }; > > &usb_1_dwc3_hs { > remote-endpoint = <&pmic_glink_hs_in>; > diff --git a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts > index e19790464a11..bece4896ca23 100644 > --- a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts > +++ b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts > @@ -593,8 +593,12 @@ &uart4 { > &usb { > status = "okay"; > }; > > +&usb_dwc3 { > + role-switch-default-mode = "host"; > +}; > + > &usb_dwc3_hs { > remote-endpoint = <&pm4125_hs_in>; > }; > > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > index 1c7de7f2db79..17d36f0ef5ab 100644 > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > @@ -661,8 +661,12 @@ &uart4 { > &usb { > status = "okay"; > }; > > +&usb_dwc3 { > + role-switch-default-mode = "host"; > +}; > + > &usb_dwc3_hs { > remote-endpoint = <&pmi632_hs_in>; > }; > > diff --git a/arch/arm64/boot/dts/qcom/sm8150-hdk.dts b/arch/arm64/boot/dts/qcom/sm8150-hdk.dts > index bac08f00b303..fe548d795490 100644 > --- a/arch/arm64/boot/dts/qcom/sm8150-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8150-hdk.dts > @@ -695,8 +695,9 @@ &usb_2 { > > &usb_1_dwc3 { > dr_mode = "otg"; > usb-role-switch; > + role-switch-default-mode = "host"; > }; > > &usb_1_dwc3_hs { > remote-endpoint = <&pm8150b_hs_in>; > diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > index e031ad4c19f4..20d5c54cfcf9 100644 > --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > @@ -847,8 +847,12 @@ &ufs_mem_phy { > &usb_1 { > status = "okay"; > }; > > +&usb_1_dwc3 { > + role-switch-default-mode = "host"; > +}; > + > &usb_1_dwc3_hs { > remote-endpoint = <&pmic_glink_hs_in>; > }; > > diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts > index a754b8fe9167..ebafcbe6859e 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts > @@ -1098,8 +1098,9 @@ &usb_1 { > > &usb_1_dwc3 { > dr_mode = "otg"; > usb-role-switch; > + role-switch-default-mode = "host"; > }; > > &usb_1_dwc3_hs { > remote-endpoint = <&pmic_glink_hs_in>; > diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts > index e0dc03a97771..1efda478b7b9 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts > @@ -1252,8 +1252,12 @@ &ufs_mem_phy { > &usb_1 { > status = "okay"; > }; > > +&usb_1_dwc3 { > + role-switch-default-mode = "host"; > +}; > + > &usb_1_dwc3_hs { > remote-endpoint = <&pmic_glink_hs_in>; > }; > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > index 26dfca0c3e05..7b05932f9c36 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > @@ -945,8 +945,12 @@ &ufs_mem_phy { > &usb_1 { > status = "okay"; > }; > > +&usb_1_dwc3 { > + role-switch-default-mode = "host"; > +}; > + > &usb_1_dwc3_hs { > remote-endpoint = <&pmic_glink_hs_in>; > }; > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > index 361b0792db4f..744bdc846e70 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > @@ -1211,8 +1211,12 @@ &ufs_mem_phy { > &usb_1 { > status = "okay"; > }; > > +&usb_1_dwc3 { > + role-switch-default-mode = "host"; > +}; > + > &usb_1_dwc3_hs { > remote-endpoint = <&pmic_glink_hs_in>; > }; > > diff --git a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts > index 092b78fd8a3b..f07a56583e7d 100644 > --- a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts > @@ -1300,8 +1300,12 @@ &ufs_mem_phy { > &usb_1 { > status = "okay"; > }; > > +&usb_1_dwc3 { > + role-switch-default-mode = "host"; > +}; > + > &usb_1_dwc3_hs { > remote-endpoint = <&pmic_glink_hs_in>; > }; > > diff --git a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts > index d6f91580ba8d..1a9a31423af4 100644 > --- a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts > @@ -839,8 +839,12 @@ &ufs_mem_phy { > &usb_1 { > status = "okay"; > }; > > +&usb_1_dwc3 { > + role-switch-default-mode = "host"; > +}; > + > &usb_1_dwc3_hs { > remote-endpoint = <&pmic_glink_hs_in>; > }; > > diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts > index bd60c2770da2..031b7ada8eb1 100644 > --- a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts > +++ b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts > @@ -1285,8 +1285,12 @@ &ufs_mem_phy { > &usb_1 { > status = "okay"; > }; > > +&usb_1_dwc3 { > + role-switch-default-mode = "host"; > +}; > + > &usb_1_dwc3_hs { > remote-endpoint = <&pmic_glink_hs_in>; > }; > >