From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Jens Axboe <axboe@suse.de>
Cc: yi.zhu@intel.com, jketreno@linux.intel.com,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ipw2200 stack reduction
Date: Thu, 29 Dec 2005 10:48:50 +0200 [thread overview]
Message-ID: <84144f020512290048g4d2a6a49hf6a41a2c0651c9ba@mail.gmail.com> (raw)
In-Reply-To: <20051228212934.GA2772@suse.de>
Hi Jens,
On 12/28/05, Jens Axboe <axboe@suse.de> wrote:
> -static int ipw_send_host_complete(struct ipw_priv *priv)
> +static struct host_cmd *ipw_host_cmd_get(u8 command, u8 len)
> {
> - struct host_cmd cmd = {
> - .cmd = IPW_CMD_HOST_COMPLETE,
> - .len = 0
> - };
> + struct host_cmd *cmd;
> +
> + cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
> + if (cmd) {
> + cmd->cmd = command;
> + cmd->len = len;
> + return cmd;
> + }
> +
> + return NULL;
A minor nitpick: you can always return cmd here.
Pekka
next prev parent reply other threads:[~2005-12-29 8:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-28 21:29 Jens Axboe
2005-12-29 8:48 ` Pekka Enberg [this message]
2005-12-29 9:00 ` Jens Axboe
2005-12-29 9:07 ` Zhu Yi
2005-12-29 9:19 ` Jens Axboe
2005-12-29 10:39 ` Pekka Enberg
2005-12-29 11:14 ` Jens Axboe
2005-12-29 11:19 ` Jens Axboe
2005-12-30 5:23 ` Zhu Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020512290048g4d2a6a49hf6a41a2c0651c9ba@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=axboe@suse.de \
--cc=jketreno@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®