From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Andrew Morton <akpm@osdl.org>
Cc: "Kevin O'Connor" <kevin@koconnor.net>,
linux-kernel@vger.kernel.org, jgarzik@pobox.com,
manfred@colorfullife.com
Subject: Re: Size-128 slab leak
Date: Thu, 2 Feb 2006 09:32:30 +0200 [thread overview]
Message-ID: <84144f020602012332g57a58f0aw373983fc6bc7368b@mail.gmail.com> (raw)
In-Reply-To: <20060201231001.0ca96bf0.akpm@osdl.org>
Hi,
On 2/2/06, Andrew Morton <akpm@osdl.org> wrote:
> @@ -2550,6 +2550,15 @@ static void *cache_alloc_debugcheck_afte
> *dbg_redzone1(cachep, objp) = RED_ACTIVE;
> *dbg_redzone2(cachep, objp) = RED_ACTIVE;
> }
> + {
> + int objnr;
> + struct slab *slabp;
> +
> + slabp = page_get_slab(virt_to_page(objp));
> +
> + objnr = (objp - slabp->s_mem) / cachep->objsize;
> + slab_bufctl(slabp)[objnr] = (unsigned long)caller;
> + }
We already have last caller in dbg_userword. Manfred, is there a
reason we're not using it?
Pekka
next prev parent reply other threads:[~2006-02-02 7:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-31 2:49 Kevin O'Connor
2006-02-02 7:10 ` Andrew Morton
2006-02-02 7:32 ` Pekka Enberg [this message]
2006-02-03 6:21 ` Manfred Spraul
2006-02-03 4:00 ` Kevin O'Connor
2006-02-03 13:21 ` Stephen Smalley
2006-02-03 15:13 ` James Morris
2006-02-04 1:13 ` Kevin O'Connor
2006-02-14 4:52 ` Jeffrey Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020602012332g57a58f0aw373983fc6bc7368b@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=kevin@koconnor.net \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®