mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Steven Whitehouse" <swhiteho@redhat.com>
Cc: "Andrew Morton" <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: GFS2 Filesystem [15/16]
Date: Sat, 25 Feb 2006 14:06:48 +0200	[thread overview]
Message-ID: <84144f020602250406v7295b185i5035baf217faec58@mail.gmail.com> (raw)
In-Reply-To: <1140793662.6400.738.camel@quoit.chygwyn.com>

On 2/24/06, Steven Whitehouse <swhiteho@redhat.com> wrote:
> +       nl = kmalloc(sizeof(struct nolock_lockspace), GFP_KERNEL);
> +       if (!nl)
> +               return -ENOMEM;
> +
> +       memset(nl, 0, sizeof(struct nolock_lockspace));

kzalloc, please.

> +       *lvbp = kmalloc(nl->nl_lvb_size, GFP_KERNEL);
> +       if (*lvbp)
> +               memset(*lvbp, 0, nl->nl_lvb_size);
> +       else
> +               error = -ENOMEM;

Likewise.

                                   Pekka

      parent reply	other threads:[~2006-02-25 12:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-24 15:07 Steven Whitehouse
2006-02-22 18:54 ` Pavel Machek
2006-02-27  8:52   ` Steven Whitehouse
2006-02-25 12:06 ` Pekka Enberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84144f020602250406v7295b185i5035baf217faec58@mail.gmail.com \
    --to=penberg@cs.helsinki.fi \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®