From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Daniel Walker" <dwalker@mvista.com>
Cc: akpm@osdl.org, Seokmann.Ju@lsil.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] megaraid gcc 4.1 warning fix
Date: Wed, 10 May 2006 09:15:31 +0300 [thread overview]
Message-ID: <84144f020605092315m30faf8f6n5c667c57e845b27f@mail.gmail.com> (raw)
In-Reply-To: <200605100256.k4A2u3lB031731@dwalker1.mvista.com>
Hi Daniel,
On 5/10/06, Daniel Walker <dwalker@mvista.com> wrote:
> -#define RDINDOOR(adapter) readl((adapter)->base + 0x20)
> -#define RDOUTDOOR(adapter) readl((adapter)->base + 0x2C)
> -#define WRINDOOR(adapter,value) writel(value, (adapter)->base + 0x20)
> -#define WROUTDOOR(adapter,value) writel(value, (adapter)->base + 0x2C)
> +#define RDINDOOR(adapter) readl((void*)((adapter)->base + 0x20))
> +#define RDOUTDOOR(adapter) readl((void*)((adapter)->base + 0x2C))
> +#define WRINDOOR(adapter,value) writel(value, (void *)((adapter)->base + 0x20))
> +#define WROUTDOOR(adapter,value) writel(value, (void*)((adapter)->base + 0x2C))
This looks wrong. adapter->base should be void __iomem *.
Pekka
next prev parent reply other threads:[~2006-05-10 6:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 2:56 Daniel Walker
2006-05-10 6:15 ` Pekka Enberg [this message]
2006-05-10 10:39 ` Alan Cox
2006-05-10 14:13 ` Daniel Walker
2006-05-10 14:21 ` Daniel Walker
2006-05-10 15:08 ` Alan Cox
2006-05-10 15:03 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020605092315m30faf8f6n5c667c57e845b27f@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=Seokmann.Ju@lsil.com \
--cc=akpm@osdl.org \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®