From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Arjan van de Ven" <arjan@infradead.org>
Cc: "Andrew Morton" <akpm@osdl.org>, "Jeff Garzik" <jeff@garzik.org>,
linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] ext3_clear_inode(): avoid kfree(NULL)
Date: Sat, 24 Jun 2006 19:19:45 +0300 [thread overview]
Message-ID: <84144f020606240919o53a38646lc4a46cd39c7a94fc@mail.gmail.com> (raw)
In-Reply-To: <1151151104.3181.30.camel@laptopd505.fenrus.org>
On 6/24/06, Arjan van de Ven <arjan@infradead.org> wrote:
> >
> > Because at that callsite, NULL is the common case. We avoid a do-nothing
> > function call most of the time. It's a nano-optimisation.
>
> but a function call is basically free, while an if () is not... even
> with unlikely()...
Yeah, but the called function has an if statement too...
Pekka
prev parent reply other threads:[~2006-06-24 16:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200606231502.k5NF2jfO007109@hera.kernel.org>
2006-06-23 18:51 ` Jeff Garzik
2006-06-23 21:24 ` Andrew Morton
2006-06-24 12:11 ` Arjan van de Ven
2006-06-24 12:20 ` Steven Rostedt
2006-06-24 12:27 ` Arjan van de Ven
2006-06-24 12:33 ` Steven Rostedt
2006-06-24 12:46 ` Arjan van de Ven
2006-06-24 12:51 ` Steven Rostedt
2006-06-24 12:53 ` Arjan van de Ven
2006-06-24 13:07 ` Steven Rostedt
2006-06-24 14:11 ` Arjan van de Ven
2006-06-24 16:06 ` Nick Piggin
2006-06-24 16:49 ` Jeremy Fitzhardinge
2006-06-24 16:55 ` Arjan van de Ven
2006-06-24 16:19 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020606240919o53a38646lc4a46cd39c7a94fc@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®