From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Heiko Carstens" <heiko.carstens@de.ibm.com>
Cc: "Christoph Lameter" <clameter@sgi.com>,
"Andrew Morton" <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] slab: always follow arch requested alignments
Date: Wed, 26 Jul 2006 14:22:55 +0300 [thread overview]
Message-ID: <84144f020607260422t668c4d8dldfcdedfe3713b73e@mail.gmail.com> (raw)
In-Reply-To: <20060722162607.GA10550@osiris.ibm.com>
Hi Heiko,
On 7/22/06, Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> Sorry, I should have mentioned it: on s390 (32 bit) we set
> #define ARCH_KMALLOC_MINALIGN 8.
> This is needed since our common I/O layer allocates data structures that need
> to have an eight byte alignment. Now, if I turn on DEBUG_SLAB, nothing works
> anymore, simply because the slab cache code ignores ARCH_KMALLOC_MINALIGN and
> uses an BYTES_PER_WORD alignment instead, which it shouldn't:
This is the bit I missed, sorry. I thought that the s390 hardware
mandates 8 byte alignment, but it really doesn't. So you're absolutely
right, you don't need to set ARCH_SLAB_MINALIGN and the alignment
calculation in slab is indeed broken for both, architecture and caller
mandated alignments.
Pekka
next prev parent reply other threads:[~2006-07-26 11:22 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-22 11:06 Heiko Carstens
2006-07-22 12:06 ` Pekka Enberg
2006-07-22 14:50 ` Christoph Lameter
2006-07-22 16:26 ` Heiko Carstens
2006-07-22 19:42 ` Christoph Lameter
2006-07-23 7:35 ` Heiko Carstens
2006-07-23 13:03 ` Christoph Lameter
2006-07-23 16:24 ` Heiko Carstens
2006-07-26 8:49 ` Heiko Carstens
2006-07-26 9:55 ` Pekka J Enberg
2006-07-26 8:50 ` [patch 1/2] slab: always consider caller mandated alignment Heiko Carstens
2006-07-26 8:51 ` [patch 2/2] slab: always consider arch " Heiko Carstens
2006-07-26 10:05 ` Pekka J Enberg
2006-07-26 10:13 ` Heiko Carstens
2006-07-26 10:37 ` Pekka J Enberg
2006-07-26 10:52 ` Heiko Carstens
2006-07-26 11:16 ` Pekka J Enberg
2006-07-26 11:26 ` Heiko Carstens
2006-07-26 18:06 ` Manfred Spraul
2006-07-26 18:19 ` Christoph Lameter
2006-07-26 18:45 ` Manfred Spraul
2006-07-26 18:59 ` Christoph Lameter
2006-07-26 19:28 ` Manfred Spraul
2006-07-26 19:31 ` Christoph Lameter
2006-07-26 19:37 ` Manfred Spraul
2006-07-26 19:47 ` Christoph Lameter
2006-07-27 5:33 ` Pekka J Enberg
2006-07-27 5:47 ` Pekka J Enberg
2006-07-27 4:24 ` Pekka J Enberg
2006-07-26 11:22 ` Pekka Enberg [this message]
2006-07-26 11:29 ` [patch] slab: always follow arch requested alignments Christoph Lameter
2006-07-26 11:32 ` Pekka J Enberg
2006-07-26 11:41 ` Christoph Lameter
2006-07-26 11:48 ` Pekka J Enberg
2006-07-26 11:49 ` Pekka J Enberg
2006-07-26 11:55 ` Christoph Lameter
2006-07-26 12:05 ` Pekka Enberg
2006-07-26 12:20 ` Christoph Lameter
2006-07-26 12:31 ` Pekka J Enberg
2006-07-26 15:24 ` Christoph Lameter
2006-07-26 15:43 ` Pekka Enberg
2006-07-26 16:25 ` Christoph Lameter
2006-07-26 18:24 ` Manfred Spraul
2006-07-26 18:28 ` Christoph Lameter
2006-07-26 12:35 ` Pekka J Enberg
2006-07-26 12:36 ` Pekka J Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020607260422t668c4d8dldfcdedfe3713b73e@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®