From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Andrew Morton" <akpm@osdl.org>
Cc: "Josef Jeff Sipek" <jsipek@cs.sunysb.edu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00 of 23][-mm] Unionfs: Stackable Namespace Unification Filesystem
Date: Fri, 13 Oct 2006 09:54:09 +0300 [thread overview]
Message-ID: <84144f020610122354s3f217a7fh1500f82da25f4739@mail.gmail.com> (raw)
In-Reply-To: <20061012135428.024d0d33.akpm@osdl.org>
On 10/12/06, Andrew Morton <akpm@osdl.org> wrote:
> Meanwhile, from a quick scan I'd say that unionfs is much, much too lightly
> commented for a review to be particularly effective. Please work on that.
Could use some basic coding style fixes too.
- Move assignments outside of if statement expression "if (err = foo_bar())"
- No C99-style comments "//"
- Use struct kmem_cache instead of the deprecated kmem_cache_t
- Don't use function-like macros as the left hand side of assignment
expression "itohi_ptr(inode) = kzalloc(size, GFP_KERNEL);". It's much
better to open-code the assignment or introduce a setter function
(e.g. inode_set_hiptr).
- Kill wrappers (e.g. unionfs_kill_block_super can be replaced with
generic_shutdown_super)
Pekka
next prev parent reply other threads:[~2006-10-13 6:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <patchbomb.1160633917@thor.fsl.cs.sunysb.edu>
2006-10-12 20:54 ` Andrew Morton
2006-10-13 6:54 ` Pekka Enberg [this message]
2006-10-13 13:41 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020610122354s3f217a7fh1500f82da25f4739@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@osdl.org \
--cc=jsipek@cs.sunysb.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®