Re: [PATCH 20 of 23] Unionfs: Internal include file

["Pekka Enberg" <penberg@cs.helsinki.fi>]

Hi,

On 10/7/06, Josef Jeff Sipek <jsipek@cs.sunysb.edu> wrote:
> +static inline void fist_copy_attr_atime(struct inode *dest,
> +                                       const struct inode *src)
> +{
> +       dest->i_atime = src->i_atime;
> +}
> +
> +static inline void fist_copy_attr_times(struct inode *dest,
> +                                       const struct inode *src)
> +{
> +       dest->i_atime = src->i_atime;
> +       dest->i_mtime = src->i_mtime;
> +       dest->i_ctime = src->i_ctime;
> +}
> +
> +static inline void fist_copy_attr_timesizes(struct inode *dest,
> +                                           const struct inode *src)
> +{
> +       dest->i_atime = src->i_atime;
> +       dest->i_mtime = src->i_mtime;
> +       dest->i_ctime = src->i_ctime;
> +       dest->i_size = src->i_size;
> +       dest->i_blocks = src->i_blocks;
> +}
> +
> +static inline void fist_copy_attr_all(struct inode *dest,
> +                                     const struct inode *src)
> +{
> +       dest->i_mode = src->i_mode;
> +       /* we do not need to copy if the file is a deleted file */
> +       if (dest->i_nlink > 0)
> +               dest->i_nlink = get_nlinks(dest);
> +       dest->i_uid = src->i_uid;
> +       dest->i_gid = src->i_gid;
> +       dest->i_rdev = src->i_rdev;
> +       dest->i_atime = src->i_atime;
> +       dest->i_mtime = src->i_mtime;
> +       dest->i_ctime = src->i_ctime;
> +       dest->i_blkbits = src->i_blkbits;
> +       dest->i_size = src->i_size;
> +       dest->i_blocks = src->i_blocks;
> +       dest->i_flags = src->i_flags;
> +}

Ecryptfs has the exact same bits. Please consolidate to common code.