From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: "Linux kernel mailing list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kcalloc: Re-order the first two out-of-order args to kcalloc().
Date: Sat, 9 Dec 2006 15:53:45 +0200 [thread overview]
Message-ID: <84144f020612090553n7fe309b7u54dd7f58424c4008@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0612081837020.6610@localhost.localdomain>
On 12/9/06, Robert P. J. Day <rpjday@mindspring.com> wrote:
> @@ -705,7 +705,7 @@ static int uss720_probe(struct usb_inter
> /*
> * Allocate parport interface
> */
> - if (!(priv = kcalloc(sizeof(struct parport_uss720_private), 1, GFP_KERNEL))) {
> + if (!(priv = kcalloc(1, sizeof(struct parport_uss720_private), GFP_KERNEL))) {
This one should be kzalloc
You really ought to send these cleanups to akpm@osdl.org with LKML
cc'd to get them merged.
next prev parent reply other threads:[~2006-12-09 13:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 23:41 Robert P. J. Day
2006-12-09 13:53 ` Pekka Enberg [this message]
2006-12-09 13:54 ` Pekka Enberg
2006-12-09 14:03 ` Robert P. J. Day
2006-12-09 14:18 ` Pekka Enberg
2006-12-09 21:55 ` Stefan Richter
2006-12-09 14:00 ` Robert P. J. Day
2006-12-09 14:13 ` Pekka Enberg
2006-12-09 14:17 ` Robert P. J. Day
2006-12-09 14:31 ` Pekka Enberg
2006-12-09 14:35 ` Robert P. J. Day
2006-12-09 21:57 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020612090553n7fe309b7u54dd7f58424c4008@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®