From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Mitchell Blank Jr" <mitch@sfgoth.com>
Cc: "Amit Choudhary" <amit2030@gmail.com>,
"Linux Kernel" <linux-kernel@vger.kernel.org>,
chas@cmf.nrl.navy.mil
Subject: Re: [PATCH 2.6.20-rc2] [BUGFIX] drivers/atm/firestream.c: Fix infinite recursion when alignment passed is 0.
Date: Thu, 4 Jan 2007 09:29:55 +0200 [thread overview]
Message-ID: <84144f020701032329v309a8e4fif130ef5d1f4b1a93@mail.gmail.com> (raw)
In-Reply-To: <20061231055906.GE35756@gaz.sfgoth.com>
On 12/31/06, Mitchell Blank Jr <mitch@sfgoth.com> wrote:
> Looking at aligned_kmalloc() it seems to be pretty badly broken -- its fallback
> if it gets a non-aligned buffer is to just try a larger size which doesn't
> necessarily fix the problem. It looks like explicitly aligning the buffer
> is a better solution.
Shouldn't we be using dma_alloc_*() here instead of abusing kmalloc()?
next prev parent reply other threads:[~2007-01-04 7:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-31 2:26 Amit Choudhary
2006-12-31 5:59 ` Mitchell Blank Jr
2007-01-04 7:29 ` Pekka Enberg [this message]
2007-01-04 2:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020701032329v309a8e4fif130ef5d1f4b1a93@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=amit2030@gmail.com \
--cc=chas@cmf.nrl.navy.mil \
--cc=linux-kernel@vger.kernel.org \
--cc=mitch@sfgoth.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®