Re: [PATCH] fix BUG_ON(!PageSlab) from fallback_alloc

["Pekka Enberg" <penberg@cs.helsinki.fi>]

Hi Hugh,

[Sorry, no access to kernel tree right now, so can't send a patch.]

On 1/4/07, Hugh Dickins <hugh@veritas.com> wrote:
> @@ -3310,7 +3310,7 @@ retry:
>                                          */
>                                         goto retry;
>                         } else {
> -                               kmem_freepages(cache, obj);
> +                               /* cache_grow already freed obj */
>                                 obj = NULL;

So, how about we rename the current cache_grow() to __cache_grow() and
move the kmem_freepages() to a higher level function like this:

static int cache_grow(struct kmem_cache *cache,
                                gfp_t flags, int nodeid)
{
        void *objp;
        int ret;

        if (flags & __GFP_NO_GROW)
                return 0;

        objp = kmem_getpages(cachep, flags, nodeid);
        if (!objp)
                return 0;

        ret = __cache_grow(cache, flags, nodeid, objp);
        if (!ret)
                kmem_freepages(cachep, objp);

        return ret;
}

And use the non-allocating __cache_grow version() in fallback_alloc() instead?