From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "joe jin" <joe.jin@oracle.com>
Cc: linux-kernel@vger.kernel.org, "Andrew Morton" <akpm@osdl.org>
Subject: Re: [PATCH] bonding: Replace kmalloc() + memset() pairs with the appropriate kzalloc() calls
Date: Fri, 12 Jan 2007 09:35:52 +0200 [thread overview]
Message-ID: <84144f020701112335v44bcf8a5see13fdbf01b700cd@mail.gmail.com> (raw)
In-Reply-To: <1168568903.10377.7.camel@joejin-pc.cn.oracle.com>
Hi Joe,
On 1/12/07, joe jin <joe.jin@oracle.com> wrote:
> @@ -788,7 +786,7 @@ static int rlb_initialize(struct bonding
>
> spin_lock_init(&(bond_info->rx_hashtbl_lock));
>
> - new_hashtbl = kmalloc(size, GFP_KERNEL);
> + new_hashtbl = kzalloc(size, GFP_KERNEL);
> if (!new_hashtbl) {
> printk(KERN_ERR DRV_NAME
> ": %s: Error: Failed to allocate RLB hash table\n",
You forgot to remove the memset here.
next prev parent reply other threads:[~2007-01-12 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-12 2:28 joe jin
2007-01-12 7:35 ` Pekka Enberg [this message]
2007-01-15 2:49 ` joe jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020701112335v44bcf8a5see13fdbf01b700cd@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@osdl.org \
--cc=joe.jin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome