From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Andrew Morton" <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, hugh@veritas.com, clameter@sgi.com
Subject: Re: [PATCH] slab: cache_grow cleanup
Date: Sun, 28 Jan 2007 13:14:57 +0200 [thread overview]
Message-ID: <84144f020701280314k21e4388cv4b04ededb7944f22@mail.gmail.com> (raw)
In-Reply-To: <20070127161229.11637b80.akpm@osdl.org>
Hi Andrew,
On 1/28/07, Andrew Morton <akpm@osdl.org> wrote:
> This gets its local interrupt state mucked up.
>
> BUG: sleeping function called from invalid context at mm/slab.c:3038
> in_atomic():0, irqs_disabled():1
> no locks held by init/1.
> irq event stamp: 656902
> hardirqs last enabled at (656901): [<c015f48b>] mod_zone_page_state+0x4b/0x50
> hardirqs last disabled at (656902): [<c0171f54>] cache_alloc_refill+0x384/0x6a0
> softirqs last enabled at (650628): [<c03a6317>] unix_release_sock+0x67/0x220
> softirqs last disabled at (650626): [<c03cfe8e>] _write_lock_bh+0xe/0x40
> [<c0103f7a>] show_trace_log_lvl+0x1a/0x30
> [<c0104682>] show_trace+0x12/0x20
> [<c0104736>] dump_stack+0x16/0x20
> [<c01175ea>] __might_sleep+0xba/0xd0
> [<c017262f>] kmem_cache_alloc+0xaf/0xd0
> [<c0172131>] cache_alloc_refill+0x561/0x6a0
> [<c0172574>] kmem_cache_zalloc+0xe4/0xf0
> [<c011cb49>] copy_process+0x89/0x1280
> [<c011dfcb>] do_fork+0x6b/0x1c0
> [<c0100e13>] sys_clone+0x33/0x40
> [<c0102edc>] sysenter_past_esp+0x5d/0x99
Hmm, alloc_slabmgmt calls kmem_cache_alloc with interrupts disabled
which triggers the warning. We won't deadlock though as we enable
interrupts in kmem_getpages in case we need to refill
cachep->slabp_cache. So the debug check is bogus when calling
kmem_cache_alloc within the slab allocator, I think.
I'll whack it some more and resend. Thanks Andrew!
Pekka
prev parent reply other threads:[~2007-01-28 11:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-09 13:40 Pekka J Enberg
2007-01-09 18:18 ` Christoph Lameter
2007-01-10 7:12 ` Pekka J Enberg
2007-01-10 14:44 ` [PATCH] " Pekka Enberg
2007-01-12 9:22 ` Pekka Enberg
2007-01-28 0:12 ` Andrew Morton
2007-01-28 11:14 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020701280314k21e4388cv4b04ededb7944f22@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®