From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Nick Piggin" <nickpiggin@yahoo.com.au>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] revoke: break cow for private mappings
Date: Wed, 28 Mar 2007 13:09:41 +0300 [thread overview]
Message-ID: <84144f020703280309i4e47f9b8w92a369aa7bc16ece@mail.gmail.com> (raw)
In-Reply-To: <460A2184.8060207@yahoo.com.au>
On 3/28/07, Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> > + ret = get_user_pages(tsk, tsk->mm, vma->vm_start,
> > + vma->vm_end-vma->vm_start, 1, 1, NULL,
> > + NULL);
>
> get_user_pages length argument is in # of pages, rather than address range,
> I think. vma_pages is what you want?
Yes.
On 3/28/07, Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> > + up_write(&mm->mmap_sem);
>
> I think you just need down_read of mmap_sem here?
Indeed. Thanks Nick.
Pekka
prev parent reply other threads:[~2007-03-28 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-27 7:14 Pekka J Enberg
2007-03-28 8:04 ` Nick Piggin
2007-03-28 10:09 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020703280309i4e47f9b8w92a369aa7bc16ece@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®