From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, virtualization@lists.osdl.org,
rusty@rustcorp.com.au, ak@suse.de, jens.axboe@oracle.com,
"Rene Herman" <rene.herman@gmail.com>
Subject: Re: [patch 8/9] lguest: the block driver
Date: Wed, 9 May 2007 13:22:43 +0300 [thread overview]
Message-ID: <84144f020705090322jc37884drc31b97879648d09@mail.gmail.com> (raw)
In-Reply-To: <200705090951.l499pdsc020409@shell0.pdx.osdl.net>
On 5/9/07, akpm@linux-foundation.org <akpm@linux-foundation.org> wrote:
> +/* Jens gave me this nice helper to end all chunks of a request. */
> +static void end_entire_request(struct request *req, int uptodate)
> +{
> + if (end_that_request_first(req, uptodate, req->hard_nr_sectors))
> + BUG();
> + add_disk_randomness(req->rq_disk);
> + blkdev_dequeue_request(req);
> + end_that_request_last(req, uptodate);
> +}
Again, I would prefer this went straight into block/ll_rw_blk.c. Rene
and I am using something similar in the new Mitsumi driver although
one of us has a bug already, we're using req->nr_sectors for this...
next prev parent reply other threads:[~2007-05-09 10:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-09 9:51 akpm
2007-05-09 10:22 ` Pekka Enberg [this message]
2007-05-09 10:29 ` Jens Axboe
2007-05-09 10:46 ` Pekka J Enberg
2007-05-09 10:54 ` Jens Axboe
2007-05-10 16:08 ` Rene Herman
2007-05-11 12:09 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020705090322jc37884drc31b97879648d09@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rene.herman@gmail.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®