From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Christoph Lameter" <clameter@sgi.com>
Cc: linux-kernel@vger.kernel.org, "Paul Mundt" <lethal@linux-sh.org>
Subject: Re: [RFC] Slab allocators: Drop support for destructors
Date: Thu, 10 May 2007 22:21:08 +0300 [thread overview]
Message-ID: <84144f020705101221y6070ed93he837c59053084fae@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0705101156190.10663@schroedinger.engr.sgi.com>
On 5/10/07, Christoph Lameter <clameter@sgi.com> wrote:
> Or are there valid reason to keep them around? It seems they were mainly
> used for list management which required them to take a spinlock. Taking a
> spinlock in a destructor is a bit risky since the slab allocators may run
> the destructors anytime they decide a slab is no longer needed.
>
> Or do we want to continue support destructors? If so why?
Well, constructors are on their way out too because they don't seem to
give the performance benefit they were designed for anymore. As for
destructors, they have been pretty useless in Linux for a long time
now and we really don't do much "complex initialization" that requires
undo (releasing resources).
Looks good to me.
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Pekka
next prev parent reply other threads:[~2007-05-10 19:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 19:00 Christoph Lameter
2007-05-10 19:21 ` Pekka Enberg [this message]
2007-05-10 19:24 ` Christoph Lameter
2007-05-10 19:58 ` William Lee Irwin III
2007-05-10 19:22 ` William Lee Irwin III
2007-05-10 23:35 ` Paul Mundt
2007-05-11 2:21 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020705101221y6070ed93he837c59053084fae@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=clameter@sgi.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®