From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Hennerich, Michael" <Michael.Hennerich@analog.com>
Cc: "Bryan Wu" <bryan.wu@analog.com>,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/32] Blackfin arch: Fix bug using usb keyboard crashes kernel
Date: Mon, 21 May 2007 15:50:32 +0300 [thread overview]
Message-ID: <84144f020705210550v1694fe74md8e19958bf2cf891@mail.gmail.com> (raw)
In-Reply-To: <84144f020705210514y396f6e67r57b86362a10f44f1@mail.gmail.com>
On 5/21/07, Hennerich, Michael <Michael.Hennerich@analog.com> wrote:
> With CONFIG_VT (drivers/char/vt.c) enabled and a USB HID keyboard connected,
> we were seeing bad pointer dereferences in drivers/char/keyboard.c
>
> In function kbd_keycode vc_cons[fg_console].d was un-initialized.
On 5/21/07, Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> Makes sense. Please consider adding this to the changelog. Thanks.
I am not an expert on this, but I don't see how vc_cons[fg_console].d
would be uninitialized. It is always set in
drivers/char/vt.c:con_init() and drivers/char/vt.c:vc_allocate(). The
conswitchp change affects vc->vc_sw but I don't see that being used in
drivers/char/keyboard.c:kbd_keycode() except indirectly via
set_console et al.
Perhaps I am missing something here?
next prev parent reply other threads:[~2007-05-21 12:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 12:07 Hennerich, Michael
2007-05-21 12:14 ` Pekka Enberg
2007-05-21 12:50 ` Pekka Enberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-05-21 13:49 Hennerich, Michael
2007-05-21 13:54 ` Pekka Enberg
2007-05-21 10:09 [PATCH 00/32] Blackfin update for 2.6.22-rc2 Bryan Wu
2007-05-21 10:09 ` [PATCH 12/32] Blackfin arch: Fix bug using usb keyboard crashes kernel Bryan Wu
2007-05-21 11:39 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020705210550v1694fe74md8e19958bf2cf891@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=Michael.Hennerich@analog.com \
--cc=akpm@linux-foundation.org \
--cc=bryan.wu@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®