mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Cyrill Gorcunov" <gorcunov@gmail.com>
Cc: "Jan Kara" <jack@suse.cz>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Christoph Hellwig" <hch@infradead.org>,
	"Ben Fennema" <bfennema@falcon.csc.calpoly.edu>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]: UDF code style conversion to kernel style
Date: Thu, 24 May 2007 21:47:42 +0300	[thread overview]
Message-ID: <84144f020705241147j5e2fa91bg229db86a63a9efb5@mail.gmail.com> (raw)
In-Reply-To: <20070523184436.GA14771@cvg>

Hi Cyrill,

On 5/23/07, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> @@ -2103,7 +1944,7 @@ long udf_block_map(struct inode *inode, sector_t block)
>  	kernel_lb_addr eloc;
>  	uint32_t elen;
>  	sector_t offset;
> -	struct extent_position epos = { NULL, 0, { 0, 0}};
> +	struct extent_position epos = {};

Bits like these in the middle of indentation fixes makes me feel
uneasy. Could we simply ask Andrew to run Lindent on the UDF sources
at some convinient point and push those to Linus like we did with
mm/slab.c if I recall correctly? Its safer to do cleanups like these
after that.

  parent reply	other threads:[~2007-05-24 18:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-23 18:44 Cyrill Gorcunov
     [not found] ` <20070524083714.GA27047@duck.suse.cz>
2007-05-24 14:34   ` Cyrill Gorcunov
2007-05-24 18:47 ` Pekka Enberg [this message]
2007-05-24 18:57   ` Randy Dunlap
2007-05-24 19:09     ` Pekka Enberg
2007-05-24 19:06   ` Cyrill Gorcunov
2007-05-24 19:28     ` Andrew Morton
2007-05-24 19:08   ` Cyrill Gorcunov
2007-05-24 19:11     ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84144f020705241147j5e2fa91bg229db86a63a9efb5@mail.gmail.com \
    --to=penberg@cs.helsinki.fi \
    --cc=akpm@linux-foundation.org \
    --cc=bfennema@falcon.csc.calpoly.edu \
    --cc=gorcunov@gmail.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®