From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765191AbXGZLIa (ORCPT ); Thu, 26 Jul 2007 07:08:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756989AbXGZLIX (ORCPT ); Thu, 26 Jul 2007 07:08:23 -0400 Received: from nz-out-0506.google.com ([64.233.162.236]:2002 "EHLO nz-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756429AbXGZLIW (ORCPT ); Thu, 26 Jul 2007 07:08:22 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=mpY2rfmokZJ4vezYtDRxKqhWdo7eZKTbIzi2vxffK73oTzXy2rhtXJV/MC6ZDYkrdOgvkWQ/2Ci5W94HqDqYN+WIR2xznVQ+WmQxz3/xwwl6I5ksjEvwJGMLY796bhCFo2rXswtxxtFnw7MNteyCx7md0TVhA50VuNKD0ZBSosQ= Message-ID: <84144f020707260408t1426a1bcs698afd74b344bbb8@mail.gmail.com> Date: Thu, 26 Jul 2007 14:08:21 +0300 From: "Pekka Enberg" To: "Peter Zijlstra" Subject: Re: [bug] SLUB & freeing locks [was: Re: 2.6.23-rc1: known regressions with patches] Cc: "Ingo Molnar" , "Michal Piotrowski" , "Andrew Morton" , "Christoph Lameter" , linux-kernel@vger.kernel.org In-Reply-To: <1185442353.8197.71.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <46A47940.7030801@googlemail.com> <20070726091048.GA7366@elte.hu> <1185441963.8197.67.camel@twins> <1185442353.8197.71.camel@twins> X-Google-Sender-Auth: ebff51d3ee5108b3 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 7/26/07, Peter Zijlstra wrote: > --- linux-2.6.orig/mm/slub.c > +++ linux-2.6/mm/slub.c > @@ -1656,6 +1656,7 @@ static void __always_inline slab_free(st > unsigned long flags; > > local_irq_save(flags); > + debug_check_no_locks_freed(object, s->size); Although it doesn't matter much, I think this should be s->objsize. Christoph? Pekka