mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Greg KH" <greg@kroah.com>
Cc: "Oliver Pinter" <oliver.pntr@gmail.com>,
	"Bastian Blank" <bastian@waldi.eu.org>,
	"Niki Denev" <ndenev@gmail.com>, "Willy Tarreau" <w@1wt.eu>,
	linux-kernel@vger.kernel.org, jens.axboe@oracle.com,
	stable@kernel.org
Subject: Re: [stable] [PATCH] kernel 2.6.24.1 still vulnerable to the vmsplice local root exploit
Date: Sun, 10 Feb 2008 19:11:05 +0200	[thread overview]
Message-ID: <84144f020802100911u7c1a3d3cm212c08d1bb3225d6@mail.gmail.com> (raw)
In-Reply-To: <20080210170544.GA25353@kroah.com>

On Feb 10, 2008 7:05 PM, Greg KH <greg@kroah.com> wrote:
> No, this is a different CVE, as it is a different problem from the
> original 09 and 10 report.
>
> It has been given CVE-2008-0600 to address this issue (09 and 10 only
> affect .23 and .24 kernels, and have been fixed.)
>
> > +             if(!access_ok(VERIFY_READ, base, len)) {
> > +                     error = -EFAULT;
> > +                     break;
> > +             }
>
> Hm, perhaps we should just properly check the len field instead?  That's
> what is being overflowed here...

Sorry, I forgot to cc you on this one:

http://lkml.org/lkml/2008/2/10/153

I don't see where the current code is checking that base is
accessible. We just check that we can copy the struct iovecs, right?

                        Pekka

  reply	other threads:[~2008-02-10 17:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-10  6:04 Niki Denev
2008-02-10  6:32 ` Willy Tarreau
2008-02-10  6:38   ` Niki Denev
2008-02-10  9:40     ` [PATCH] " Niki Denev
2008-02-10 12:04       ` Oliver Pinter
2008-02-10 12:22       ` Bastian Blank
2008-02-10 12:39         ` Niki Denev
2008-02-10 12:47           ` Bastian Blank
2008-02-10 12:54             ` Niki Denev
2008-02-10 13:02             ` Oliver Pinter
2008-02-10 17:05               ` [stable] " Greg KH
2008-02-10 17:11                 ` Pekka Enberg [this message]
2008-02-10 17:44                 ` Oliver Pinter
2008-02-10 17:48                 ` Oliver Pinter
2008-02-10 13:48         ` Niki Denev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84144f020802100911u7c1a3d3cm212c08d1bb3225d6@mail.gmail.com \
    --to=penberg@cs.helsinki.fi \
    --cc=bastian@waldi.eu.org \
    --cc=greg@kroah.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ndenev@gmail.com \
    --cc=oliver.pntr@gmail.com \
    --cc=stable@kernel.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®