From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "linux-os (Dick Johnson)" <linux-os@analogic.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>,
jaharkes@cs.cmu.edu, "Andrew Morton" <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs/coda: remove static inline forward declarations
Date: Wed, 13 Feb 2008 16:54:11 +0200 [thread overview]
Message-ID: <84144f020802130654w51901fb1hf29d39ba86d87414@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0802130838100.4463@chaos.analogic.com>
On Feb 13, 2008 3:43 PM, linux-os (Dick Johnson) <linux-os@analogic.com> wrote:
> You should not remove things just because you don't think they
> are necessary. They do no harm and removing them can cause
> code checking tools to issue diagnostic messages.
Err, no, Ilpo's patch looks good and the redundant declarations should
be removed. Andrew, please queue up this patch.
Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>
next prev parent reply other threads:[~2008-02-13 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 12:22 Ilpo Järvinen
2008-02-13 13:43 ` linux-os (Dick Johnson)
2008-02-13 14:15 ` Ilpo Järvinen
2008-02-13 15:55 ` linux-os (Dick Johnson)
2008-02-13 14:54 ` Pekka Enberg [this message]
2008-02-13 14:24 ` Jan Harkes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020802130654w51901fb1hf29d39ba86d87414@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=jaharkes@cs.cmu.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-os@analogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®