From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Nishanth Aravamudan" <nacc@us.ibm.com>
Cc: "Julia Lawall" <julia@diku.dk>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/6] fs/direct-io.c: Use DIV_ROUND_UP
Date: Thu, 14 Feb 2008 20:18:02 +0200 [thread overview]
Message-ID: <84144f020802141018i235d3adfu13a84d124dc3964e@mail.gmail.com> (raw)
In-Reply-To: <20080214173850.GC14191@us.ibm.com>
Hi Nishanth,
On Thu, Feb 14, 2008 at 7:38 PM, Nishanth Aravamudan <nacc@us.ibm.com> wrote:
> Is it just me, or does
>
> ((user_addr + iov[seg].iov_len + PAGE_SIZE - 1)/PAGE_SIZE - user_addr/PAGE_SIZE)
>
> not simplify to
>
> = ((iov[seg].iov_len + PAGE_SIZE - 1)/PAGE_SIZE + user_addr/PAGE_SIZE - user_addr/PAGE_SIZE)
>
> = ((iov[seg].iov_len + PAGE_SIZE - 1)/PAGE_SIZE)
>
> = DIV_ROUND_UP(iov[seg].iov_len, PAGE_SIZE)
>
> CMIIW.
I double-checked this and I believe you're correct. It's simpler to
see when you do:
x = user_addr
y = iov[seg].iov_len
z = PAGE_SIZE
So
(x + y + z - 1)/z - x/z
= [x + (y + z - 1)]/z - x/z
= [xz + z(y + z - 1)]/z^2 - x/z
= x/z + (y + z - 1)/z - x/z
And the rest follows from your simplifications.
Pekka
next prev parent reply other threads:[~2008-02-14 18:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 15:14 Julia Lawall
2008-02-14 17:25 ` Zach Brown
2008-02-14 17:38 ` Nishanth Aravamudan
2008-02-14 18:18 ` Pekka Enberg [this message]
2008-02-14 19:50 ` Julia Lawall
2008-02-14 22:16 ` Mariusz Kozlowski
2008-02-14 23:37 ` Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020802141018i235d3adfu13a84d124dc3964e@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®