From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Thomas Gleixner" <tglx@linutronix.de>
Cc: "Andi Kleen" <ak@suse.de>, "Ingo Molnar" <mingo@elte.hu>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, "Andy Whitcroft" <andyw@uk.ibm.com>
Subject: Re: [patch] checkpatch.pl: revert wrong --file message
Date: Sat, 16 Feb 2008 12:27:33 +0200 [thread overview]
Message-ID: <84144f020802160227u59c9959emb905808cc7141f2b@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.1.00.0802161026550.7583@apollo.tec.linutronix.de>
Hi,
On Feb 16, 2008 12:18 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> People, who do cleanups - I'm not talking about running lindent here -
> read through the code while they fix it up.
>
> Actually they find bugs that way or at least come up with useful
> questions about code which is not obvious in the first place.
>
> Discouraging such cleanups with a pretty offensive warning is
> counterproductive.
Well, it's not just about cleanup patches submitted by "newbies". I
use checkpatch for development too and the warning is real PITA for
that.
next prev parent reply other threads:[~2008-02-16 10:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 16:52 Ingo Molnar
2008-02-15 17:15 ` Andi Kleen
2008-02-16 10:18 ` Thomas Gleixner
2008-02-16 10:27 ` Pekka Enberg [this message]
2008-02-16 11:04 ` Cyrill Gorcunov
2008-02-16 22:56 ` Andy Whitcroft
2008-02-16 23:47 ` Thomas Gleixner
2008-02-18 10:07 ` Andi Kleen
2008-02-18 10:16 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020802160227u59c9959emb905808cc7141f2b@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=ak@suse.de \
--cc=andyw@uk.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®