From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759072AbYCBUsv (ORCPT ); Sun, 2 Mar 2008 15:48:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753036AbYCBUsm (ORCPT ); Sun, 2 Mar 2008 15:48:42 -0500 Received: from el-out-1112.google.com ([209.85.162.183]:38116 "EHLO el-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752183AbYCBUsl (ORCPT ); Sun, 2 Mar 2008 15:48:41 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=WZVEQXC7VkdG6nl/2m4dN0724I54cgoY9rV04/WXe/4220Ijd2Qk2dSFnWxW4m2UClwviHEI3bAZ/GmT1cC7HtbyN8RnVhTV5W4qM6rYafQOhqpY+BpycPV3Vn7VEBU8ZElwIzXLi6NVuZ5J6HweMpn4npVqHKVQOCy3g5YD4Pw= Message-ID: <84144f020803021248r53c3d179ga514c0c426e1e2d6@mail.gmail.com> Date: Sun, 2 Mar 2008 22:48:39 +0200 From: "Pekka Enberg" To: "Cyrill Gorcunov" Subject: Re: [PATCH] slub: fix possible NULL pointer dereference Cc: "Christoph Lameter" , LKML , "Peter Zijlstra" , "Rik van Riel" , "Andrew Morton" In-Reply-To: <20080302202824.GA9032@cvg> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080302202824.GA9032@cvg> X-Google-Sender-Auth: 0df936dd6c869c1c Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 2, 2008 at 10:28 PM, Cyrill Gorcunov wrote: > This patch fix possible NULL pointer dereference if kzalloc > failed. To be able to return proper error code the function > return type is changed to ssize_t (according to callees and > sysfs definitions). > > Signed-off-by: Cyrill Gorcunov Looks good to me. Reviewed-by: Pekka Enberg