From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: JosephChan@via.com.tw
Cc: akpm@linux-foundation.org, geert@linux-m68k.org,
linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [Linux-fbdev-devel] [PATCH 1/9] viafb: VIA Frame Buffer Device Driver
Date: Wed, 7 May 2008 14:16:41 +0300 [thread overview]
Message-ID: <84144f020805070416t321928ben4cd66a8235a74cbc@mail.gmail.com> (raw)
In-Reply-To: <C80EF34A3D2E494DBAF9AC29C7AE4EB806F67724@exchtp03.taipei.via.com.tw>
Hi Joseph,
On Wed, May 7, 2008 at 1:55 PM, <JosephChan@via.com.tw> wrote:
> Signed-off-by: Joseph Chan <josephchan@via.com.tw>
The patch has plento of coding style problems so you probably want to
run scripts/checkpatch and re-submit. Is the documentation available
somewhere for this device btw?
next prev parent reply other threads:[~2008-05-07 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <C80EF34A3D2E494DBAF9AC29C7AE4EB806F67705@exchtp03.taipei.via.com.tw>
2008-05-07 10:55 ` JosephChan
2008-05-07 11:16 ` Pekka Enberg [this message]
2008-05-07 15:19 ` Randy Dunlap
2008-05-20 12:56 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020805070416t321928ben4cd66a8235a74cbc@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=JosephChan@via.com.tw \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®