mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Vegard Nossum" <vegard.nossum@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Rob Landley" <rob@landley.net>
Subject: Re: [RFC/PATCH] printk: detect incomplete lines
Date: Mon, 12 May 2008 14:56:28 +0300	[thread overview]
Message-ID: <84144f020805120456r14436eend416e079ea88be9c@mail.gmail.com> (raw)
In-Reply-To: <20080512114925.GA29407@damson.getinternet.no>

On Mon, May 12, 2008 at 2:49 PM, Vegard Nossum <vegard.nossum@gmail.com> wrote:
>  This printk() problem has been bugging me for a long time. Consider the
>  following code:
>
>  diff --git a/init/main.c b/init/main.c
>  index ddada7a..777e02d 100644
>  --- a/init/main.c
>  +++ b/init/main.c
>  @@ -452,17 +452,38 @@ static void __init setup_command_line(char *command_line)
>   * gcc-3.4 accidentally inlines this function, so use noinline.
>   */
>
>  +static void printk_thread(const char *msg, unsigned long wait)
>  +{
>  +       int i = 0;
>  +
>  +       while(true) {
>  +               if (i == 0)
>  +                       printk(KERN_INFO "Here we go: ");
>  +
>  +               printk("%s%s", msg, i < 7 ? ", " : "\n");

You are supposed to use KERN_CONT here.

  reply	other threads:[~2008-05-12 11:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-12 11:49 Vegard Nossum
2008-05-12 11:56 ` Pekka Enberg [this message]
2008-05-12 12:00   ` Vegard Nossum
2008-05-13 10:54     ` Andi Kleen
2008-05-13 15:31       ` Vegard Nossum
2008-05-12 15:35 ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84144f020805120456r14436eend416e079ea88be9c@mail.gmail.com \
    --to=penberg@cs.helsinki.fi \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob@landley.net \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®